[pwm] Correction to heartbeat mode #25717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswarbrick
reviewed
Dec 20, 2024
Contributor
rswarbrick
left a comment
rswarbrick
left a comment
There was a problem hiding this comment.
A nitty comment, but this looks really nice to me. I particularly like the use of XOR, "taking reverse seriously" :-D
Heartbeat direction reversal was premature in the event of passing the target duty cycle (non-wrapping case). The heartbeat direction shall only be changed at the end of the 'X'+1 pulse cycles for the current duty cycle. Signed-off-by: Adrian Lees <[email protected]>
alees24
force-pushed
the
pwm-htbt-fix
branch
from
80ead96 to
915c539
Compare
rswarbrick
approved these changes
Dec 20, 2024
Contributor
|
CHANGE AUTHORIZED: hw/ip/pwm/rtl/pwm_chan.sv This causes a behaviour change, but only by fixing a bug! Looks like the right thing to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heartbeat direction reversal was premature in the event of passing the target duty cycle (non-wrapping case). The heartbeat direction shall only be changed at the end of the 'X'+1 pulse cycles for the current duty cycle.
This was found using the improved DV which is ongoing; the current DV environment overlooked this deviation from the specification.