[sw,e2e] Add SRAM execution owner config testcases #28057
Conversation
| owner_keydata_t owner = OWNER_KEYDATA; | ||
| ownership_state_t state = bootdata->ownership_state; | ||
|
|
||
| #ifndef TEST_OWNER_FORCE_UPDATE |
There was a problem hiding this comment.
I don't think we need this and introducing an #ifdef around this policy logic scares me.
The way this is handled in other tests which require a particular owner configuration is to clear the bitstream before the test. We also clear it after the test (changes_otp=True) to ensure the owner config doesn't survive to cause problems in later tests.
You can see this in action in the rescue and ownership tests, for example:
test_cmd = """
--exec="transport init"
--exec="fpga clear-bitstream"
--exec="fpga load-bitstream {bitstream}"
--exec="bootstrap --clear-uart=true {firmware}"
--exec="console --non-interactive --exit-success='{exit_success}' --exit-failure='{exit_failure}'"
no-op
""",
As an aside, it might be better if we had a test parameter that indicated that we wanted to clear the bitstream before the test, but I don't think we should develop that in this PR.
There was a problem hiding this comment.
Changes applied. Thanks!
This change adds an end-to-end test for SRAM execution mode owner config switches. The test verifies that the SRAM execution mode can be enabled, disabled, and disabled+locked. Change-Id: I5a98e91586ae4be6a9362adaa9b1a983c1082bf9 Signed-off-by: Yi-Hsuan Deng <[email protected]>
Change-Id: I7d09a54a5278e923d5489a9d3acae078d6616037 Signed-off-by: Yi-Hsuan Deng <[email protected]>
Change-Id: I7d09a54a5278e923d5489a9d3acae078d6616037 Signed-off-by: Yi-Hsuan Deng <[email protected]>
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin master
git worktree add -d .worktree/backport-28057-to-master origin/master
cd .worktree/backport-28057-to-master
git switch --create backport-28057-to-master
git cherry-pick -x 634ffcb619997f0b58edf451acb0e4d6a9077ea2 |
lowrisc-ci
bot
added
the
Manually CherryPick
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin master
git worktree add -d .worktree/backport-28057-to-master origin/master
cd .worktree/backport-28057-to-master
git switch --create backport-28057-to-master
git cherry-pick -x 634ffcb619997f0b58edf451acb0e4d6a9077ea2 |
3 participants
This change adds an end-to-end test for SRAM execution mode owner config switches.
The test verifies that the SRAM execution mode can be enabled, disabled, and disabled+locked.