[opentitantool] introduce ImageType manifest extension #28324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new extension contents is a 32 bit value which can be used by the owner to mark image for different applications built for the same chip. Tested by creating a manifest including the new extension and observing the generated binary. Change-Id: I16c5dca791b379adf98c6d4e2dfd6845844c8d65 Signed-off-by: Vadim Bendebury <[email protected]>
Author
|
This defines an optional extension which sets an additional image identifier, a 32 bit value. |
vbendeb
requested review from
cfrantz and
timothytrippel
and removed request for
cfrantz
timothytrippel
approved these changes
Sep 22, 2025
Contributor
timothytrippel
left a comment
timothytrippel
left a comment
There was a problem hiding this comment.
Let's also cherry-pick this to master branch after merging.
timothytrippel
merged commit 4933614
into
lowRISC:earlgrey_1.0.0
64 of 66 checks passed
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin master
git worktree add -d .worktree/backport-28324-to-master origin/master
cd .worktree/backport-28324-to-master
git switch --create backport-28324-to-master
git cherry-pick -x 0d4cca1598dba98e94752533a3e4a4c09b36bf07 |
lowrisc-ci
bot
added
the
Manually CherryPick
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin master
git worktree add -d .worktree/backport-28324-to-master origin/master
cd .worktree/backport-28324-to-master
git switch --create backport-28324-to-master
git cherry-pick -x 0d4cca1598dba98e94752533a3e4a4c09b36bf07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new extension contents is a 32 bit value which can be used by the owner to mark image for different applications built for the same chip.
Tested by creating a manifest including the new extension and observing the generated binary.
Change-Id: I16c5dca791b379adf98c6d4e2dfd6845844c8d65