[cryptolib] Use hardened_* functions in KMAC driver
#29155
Merged
+33
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid leakage when unmasking the digest, switch to the SCA resilient `hardened_xor` function. Signed-off-by: Pascal Nasahl <[email protected]>
nasahlpa
requested review from
andrea-caforio,
johannheyszl,
siemen11 and
vogelpi
nasahlpa
commented
Jan 20, 2026
| } | ||
| for (size_t i = 0; i * sizeof(uint32_t) < key->len; i++) { | ||
| abs_mmio_write32( | ||
| kBase + KMAC_KEY_SHARE0_0_REG_OFFSET + i * sizeof(uint32_t), |
Member
Author
There was a problem hiding this comment.
Hm no I don't think so, we want to access byte 0 of share0:
https://opentitan.org/book/hw/ip/kmac/doc/registers.html#key_share0
Use hardened_memcpy for: - Reading the KMAC state register share 0 and 1 - Writing the KMAC key shares 0 and 1 Signed-off-by: Pascal Nasahl <[email protected]>
nasahlpa
force-pushed
the
kmac_hardened_xor
branch
from
9e8ba95 to
5067454
Compare
nasahlpa
added
the
CherryPick:earlgrey_1.0.0
siemen11
approved these changes
Jan 20, 2026
Contributor
siemen11
left a comment
siemen11
left a comment
There was a problem hiding this comment.
Thank you Pascal, this moves the KMAC more in using the standard cryptolib functions
h-filali
approved these changes
Feb 10, 2026
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-29155-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-29155-to-earlgrey_1.0.0
git switch --create backport-29155-to-earlgrey_1.0.0
git cherry-pick -x 159e3d43c916ce2dad8f63879a749d42dda052a3 50674547b2e856edea2309a136befe23d5a191f6 |
lowrisc-ci
bot
added
the
Manually CherryPick
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin earlgrey_1.0.0
git worktree add -d .worktree/backport-29155-to-earlgrey_1.0.0 origin/earlgrey_1.0.0
cd .worktree/backport-29155-to-earlgrey_1.0.0
git switch --create backport-29155-to-earlgrey_1.0.0
git cherry-pick -x 159e3d43c916ce2dad8f63879a749d42dda052a3 50674547b2e856edea2309a136befe23d5a191f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mitigate fault injection & SCA attacks, use the
hardened_*functions.