Backport 27176 ([opentitanlib] Support ECDSA and SPX+ pem signature) #29175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
requested review from
cfrantz,
jwnrt and
timothytrippel
and removed request for
a team
pamaury
force-pushed
the
backport_27176
branch
from
2510b40 to
4964173
Compare
This introduces the ability to parse ECDSA signature from PEM-encoded files. This change adds a new `from_pem` method to `EcdsaRawSignature` to handle this encoding format. The PEM parsing logic incorporates a new utility function (`clean_pem_bytes_for_parsing`) within a new `util` module. This utility handles deviations from strict RFC 7468 PEM formatting, ensuring compatibility with a wider range of generated PEM files. Signed-off-by: Anthony Chen <[email protected]> (cherry picked from commit 174f06c)
This introduces support for parsing SPX+ signatures from PEM-encoded files. A new `SpxRawSignature` struct is introduced to encapsulate raw SPX+ signature data. Its `read_from_file` method now detects whether a signature file is in raw binary format (based on size) or PEM format. The `opentitantool` commands (`image` and `spx`) have been updated to leverage the new `SpxSignature` struct and its file reading capabilities. Signed-off-by: Anthony Chen <[email protected]> (cherry picked from commit 4d3dd86)
pamaury
force-pushed
the
backport_27176
branch
from
4964173 to
e39df22
Compare
timothytrippel
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27176.
Note: the fact that this PR introduces a module in
sw/host/opentitanlib/utilis not great in my opnion. Indeed, it's not part of otlib because otlib depends on which sphincsplus which depends on this library so this would cause a loop if the code was included in there. On the other hand, it's still in theopentitanlibdirectory and is poorly namedutil. I think this should be changed in the future. @jwnrt @cfrantz