Backport 27235 ([opentitanlib] add option to ignore SPI console frame numbers) #29178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
requested review from
jwnrt and
timothytrippel
and removed request for
a team
pamaury
force-pushed
the
backport_27235
branch
from
ee71576 to
e53b9f4
Compare
pamaury
force-pushed
the
backport_27235
branch
from
e53b9f4 to
bec2ff6
Compare
timothytrippel
approved these changes
Jan 30, 2026
When opentitanlib is invoked via an external C/C++ wrapper library, the SpiConsoleDevice object is reinstantiated repeatedly to comply with Rust's ownership rules (and satisfy the borrow checker). On each reinstantiation of the SpiConsoleDevice struct, the next expected frame number is reset to 0. This causes the SpiConsoleDevice to ignore a valid frame when used through an external wrapper library, as is the case with the OtlibWrapper used in the opentitan-provisioning repo. This was causing CI issues in lowRISC/opentitan-provisioning#165. As such, this provides a mechanism for users of the SpiConsoleDevice to ignore the frame number, which frankly is not necessary when the SpiConsoleDevice is used alongside the TX-indicator GPIO feature. This feature does not make use of a circular transmit buffer, but rather transmits only a single frame in the buffer at a time. Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit 9ca5d54)
pamaury
force-pushed
the
backport_27235
branch
from
bec2ff6 to
a700160
Compare
Contributor
Author
|
CI failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27235. Depends on #29173 and #29167, only review last commit