Skip to content

Backport 27276 ([manuf] Disqualify staging targets for offline signing) #29179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pamaury merged 1 commit into from
Jan 28, 2026
Merged

Backport 27276 ([manuf] Disqualify staging targets for offline signing) #29179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions sw/device/silicon_creator/manuf/base/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ load(
load(
"//sw/device/silicon_creator/manuf/base:provisioning_inputs.bzl",
"EARLGREY_SKUS",
"disqualified_for_signing",
)
load(
"//sw/device/silicon_creator/rom/e2e:defs.bzl",
Expand Down Expand Up @@ -401,8 +402,6 @@ filegroup(
EXT_SIGNED_PERSO_BINS,
)

_DISQUALIFIED_FOR_SIGNING = ["em00"]

[
offline_presigning_artifacts(
name = "provisioning_{}".format(sku),
Expand All @@ -414,7 +413,7 @@ _DISQUALIFIED_FOR_SIGNING = ["em00"]
tags = ["manual"],
)
for sku, data in EARLGREY_SKUS.items()
if data["otp"] not in _DISQUALIFIED_FOR_SIGNING
if not disqualified_for_signing(sku, data)
]

pkg_tar(
Expand All @@ -423,7 +422,7 @@ pkg_tar(
srcs = [
":provisioning_{}".format(sku)
for sku, data in EARLGREY_SKUS.items()
if data["otp"] not in _DISQUALIFIED_FOR_SIGNING
if not disqualified_for_signing(sku, data)
],
mode = "0644",
tags = ["manual"],
Expand All @@ -435,21 +434,21 @@ offline_signature_attach(
srcs = [
":provisioning_{}".format(sku)
for sku, data in EARLGREY_SKUS.items()
if data["otp"] not in _DISQUALIFIED_FOR_SIGNING
if not disqualified_for_signing(sku, data)
],
ecdsa_signatures = [
"//sw/device/silicon_creator/manuf/base/signatures:ecdsa_signatures",
] + depset([
"{}:ecdsa_signatures".format(data["signature_prefix"])
for sku, data in EARLGREY_SKUS.items()
if data["signature_prefix"] and data["otp"] not in _DISQUALIFIED_FOR_SIGNING
if data["signature_prefix"] and not disqualified_for_signing(sku, data)
]).to_list(),
spx_signatures = [
"//sw/device/silicon_creator/manuf/base/signatures:spx_signatures",
] + depset([
"{}:spx_signatures".format(data["signature_prefix"])
for sku, data in EARLGREY_SKUS.items()
if data["signature_prefix"] and data["otp"] not in _DISQUALIFIED_FOR_SIGNING
if data["signature_prefix"] and not disqualified_for_signing(sku, data)
]).to_list(),
tags = ["manual"],
)
8 changes: 8 additions & 0 deletions sw/device/silicon_creator/manuf/base/provisioning_inputs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,11 @@ EARLGREY_SKUS = {
# "offline": True,
# },
} | EXT_EARLGREY_SKUS

# TODO(lowRISC#27275): Refactor build/signing rules for perso binaries.
def disqualified_for_signing(name, data):
if "staging" in name:
return True
if "em00" in data["otp"]:
return True
return False
Loading