Backport 27131 ([hsmtool] Add support for prehashing in CloudKMS) #29180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudKMS requires the `public_key_format` parameter when retrieving PQC public key material. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 6aadfdf)
Some HSMs/backends require specifying the SLH-DSA signing domain that a key will use during keygen. Adjust the SPX trait and implementations to take the domain during keygen and import, and to return the associated domain during "key info" operations. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 4feca91)
pamaury
requested review from
cfrantz and
jwnrt
and removed request for
a team
pamaury
force-pushed
the
backport_27131
branch
from
9e340b0 to
ca88b50
Compare
CloudKMS is adding support for SLH-DSA signatures using the prehashed domain. Add support for keygen, sign and verify with prehashing. 1. Check the domain during keygen. CloudKMS encodes both the algorithm and domain into their notion of algorithm, so you must provide the domain at keygen time. 2. Check that the `domain` given for sign and verify matches the domain for which the key was generated. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 57fd70b)
pamaury
force-pushed
the
backport_27131
branch
from
ca88b50 to
b3c20b8
Compare
cfrantz
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27131