Skip to content

[bazel] Modify Bazel configs to support OpenTitan being a nonroot module (backport) #29191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jwnrt merged 1 commit into from
Jan 28, 2026
Merged

[bazel] Modify Bazel configs to support OpenTitan being a nonroot module (backport) #29191

jwnrt merged 1 commit into from
Jan 28, 2026

Conversation

@jwnrt
Copy link
Contributor

@jwnrt jwnrt commented Jan 27, 2026 •
edited
Loading

Manual backport of #28144 (only one commit needed).

This change tweaks Bazel configs to support the repository's use as a nonroot Bazel module. Changes include

Using absolute/explicit labels as opposed to relative
Inlining include calls
removing raw string comparisons of labels

Changes have been tested in a parent build environment.

@amit-kumarh @jwnrt
[bazel] Refactor platform selection
d3428af 
Change host vs device platform selection to use a constraint setting
rather than a string comparison, as these don't work across bazel
modules.

Signed-off-by: Amit Kumar-Hermosillo <[email protected]>
(cherry picked from commit 00a2d37)
@jwnrt jwnrt requested a review from pamaury January 27, 2026 16:41
@jwnrt jwnrt marked this pull request as ready for review January 27, 2026 16:42
@jwnrt jwnrt requested a review from cfrantz as a code owner January 27, 2026 16:42
pamaury
pamaury approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@pamaury pamaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would like eventually to merge this change from the EB rework which uses platform to correctly handle toolchain options: 7e9b231

@jwnrt jwnrt added this pull request to the merge queue Jan 28, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026
@jwnrt jwnrt added this pull request to the merge queue Jan 28, 2026
Merged via the queue into lowRISC:master with commit 2442b34 Jan 28, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pamaury pamaury pamaury approved these changes

@cfrantz cfrantz cfrantz approved these changes

Assignees

No one assigned

Labels

MergeBack:1.0.0 to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jwnrt @pamaury @cfrantz @amit-kumarh