Backport 27123 ([rom_ext] Integrate ISFB into the boot flow ) #29214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
requested review from
jwnrt and
timothytrippel
and removed request for
a team
cfrantz
approved these changes
Jan 29, 2026
pamaury
force-pushed
the
backport_27123
branch
3 times, most recently
from
3074c08 to
d84a2b5
Compare
Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 2baf7bd)
The Integrator Specific Firmware Binding (ISFB) feature allows an owner to configure an INFO page to hold application firmware binding information. The binding information allows owners to implement an anti-rollback policy with a strike-out mask mechanism and per-product binding based on product identifier words stored in the INFO page. The owner can then apply an extension to the application firmware manifest to specify the strikeout binding (ie: number of unstruck words) and a series of product expressions which match against the product words. This feature is currently documented in this [mini-spec](https://docs.google.com/document/d/19oQtqgDdFU6qunbwgkwNaizYUNCzdLVqmnBpLaDvX5I/edit?pli=1&tab=t.0#heading=h.bw1472fp996n). Signed-off-by: Miguel Osorio <[email protected]> (cherry picked from commit ac682fe)
The Integrator Specific Firmware Binding feature allows an owner to configure an INFO page to hold application firmware binding information. The binding information allows owners to implement an anti-rollback policy with a strike-out mask mechanism and per-product binding based on product identifier words stored in the INFO page. Add tests to: 1. Check the ISFB page configuration. Ensure that it is not erasable unless the erase extension is present and the other erase constraints are met. 2. Check that an unconstrained firmware image can execute. 3. Check that an image with an ISFB extension that meets the requirements can execute. 4. Check that an image with a bad product expression cannot execute. 5. Check that an image with a bad strike mask cannot execute. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit 91ff00c)
The ISFB tests update the owner configuration in a way that might interfere with other tests. Use the `changes_otp` flag to ensure that the bitstream and flash pages are cleared between tests. Signed-off-by: Chris Frantz <[email protected]> (cherry picked from commit e361d08)
pamaury
force-pushed
the
backport_27123
branch
from
6747027 to
4bc68e5
Compare
Contributor
Author
|
CI failure is unrelated |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27123 and #27318. Depends on #29208, only review last 4 commits.