Backport 27256 ([ujson] enable skipping CRC sent with UJSON payloads) #29238
+158
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
requested review from
alees24,
jwnrt and
timothytrippel
and removed request for
a team
pamaury
force-pushed
the
backport_27256
branch
from
db4593f to
ff68c78
Compare
pamaury
force-pushed
the
backport_27256
branch
from
ff68c78 to
46d3cfc
Compare
cfrantz
approved these changes
Feb 5, 2026
pamaury
force-pushed
the
backport_27256
branch
2 times, most recently
from
cfde452 to
ee8e3a6
Compare
In manufacturing ATE environments, constant sized UJSON strings are preferred. CRCs are variable in length. Therefore, we enable setting the CRC to a fixed value of 0 and skipping the check on the host side. Signed-off-by: Tim Trippel <[email protected]> (cherry picked from commit 9a66cc2)
pamaury
force-pushed
the
backport_27256
branch
from
1ae2ac5 to
f0dcfbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27256. Depends on #29237, only review the last commit