Skip to content

Backport 27424 ([rom_ext,dice] Add hash integrity check for DICE pages) #29250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pamaury wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Backport 27424 ([rom_ext,dice] Add hash integrity check for DICE pages) #29250

pamaury wants to merge 8 commits into from

Conversation

@pamaury
Copy link
Contributor

@pamaury pamaury commented Feb 4, 2026

Backport #27424

@pamaury pamaury requested a review from a team as a code owner February 4, 2026 15:07
@pamaury pamaury requested review from cfrantz, jwnrt, moidx and timothytrippel and removed request for a team February 4, 2026 15:07
sasdf and others added 8 commits February 9, 2026 18:38
@sasdf @pamaury
[dice] Regenerate CDI chain upon cache parsing error
3545f74 
Change-Id: Ia980fc98dcf088500c179d746fc235de5b0db105
Signed-off-by: Yi-Hsuan Deng <[email protected]>
(cherry picked from commit ff82119)
@sasdf @pamaury
[dice] Remove unnecessary UDS skip for CDI page
25612b4 
The UDS, now located on the dedicated Factory page for all SKUs (X509/CWT),
we no longer requires this skip.

Change-Id: I34f16b9db049cc71658116d06d07f545cf9f0d84
Signed-off-by: Yi-Hsuan Deng <[email protected]>
(cherry picked from commit 50890ca)
@sasdf @pamaury
[dice] Reserve the digest region at the end of dice page
b5312dd 
Change-Id: Iea8c8d2315d466a396d5d1064b8b77a48fb28e30
Signed-off-by: Yi-Hsuan Deng <[email protected]>
(cherry picked from commit 7d0f11f)
@sasdf @pamaury
[dice] Seal CDI page with hash
5842142 
Adds a hash to the CDI cache page to ensure its integrity after an update,
mitigating corruption risks from resets or partial write.

Change-Id: I163b994dd4b4c218a8791c5701e4c40341cda8fc
Signed-off-by: Yi-Hsuan Deng <[email protected]>
(cherry picked from commit 783bfdf)
@sasdf @pamaury
[dice] Seal CDI page with hash during perso
fb9d2c6 
This change introduces a flash page hash checksum similar to the one in ROM_EXT,
applicable to both UDS and CDI pages.

Change-Id: Ic4764bc3bda79cecd5faef31f1efa562f1c758a1
Signed-off-by: Yi-Hsuan Deng <[email protected]>
(cherry picked from commit df408aa)
@sasdf @pamaury
[dice] Check CDI page hash sealing
9352c5e 
This change validates the integrity hash of the CDI page and regenerates the
page if it is found to be corrupted.

Change-Id: Id5ab836cf1dd3e1a10dd27a19cd948d0b7c8abc4
Signed-off-by: Yi-Hsuan Deng <[email protected]>
(cherry picked from commit 5c1f5b8)
@sasdf @pamaury
[dice] Add e2e test recovering from corrupted cdi
e1286db 
Change-Id: I4d8106a7b8b80d8199766323cc0e1a152cf8276b
Signed-off-by: Yi-Hsuan Deng <[email protected]>
(cherry picked from commit 1bf1a72)
@jwnrt @pamaury
[dice_chain] Handle flash_ctrl_recov_err in modif_digest
92ef7c0 
This test intentionally trigger recoverable errors. These lead to
alerts which we acknowledge in this commit.

Signed-off-by: James Wainwright <[email protected]>
(partially cherry picked from commit fc0b671)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfrantz cfrantz cfrantz approved these changes

@moidx moidx Awaiting requested review from moidx moidx is a code owner automatically assigned from lowRISC/ot-c-cpp-reviewers

@timothytrippel timothytrippel Awaiting requested review from timothytrippel

@jwnrt jwnrt Awaiting requested review from jwnrt

Assignees

No one assigned

Labels

MergeBack:1.0.0 to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pamaury @cfrantz @sasdf @jwnrt