Backport 27443 ([rom_ext,rescue] Fix allowlist for reboot mode) #29256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamaury
requested review from
alees24 and
jwnrt
and removed request for
a team
cfrantz
approved these changes
Feb 5, 2026
The reboot mode is always allowed in `rescue_validate_mode`. H owever, the rescue protocol will still crash with `kErrorRescueBadMode` when the reboot command is not allowed. This commit fixes this issue by moving those special commands before the `owner_rescue_command_allowed` checks. Change-Id: I2c632c516825df514f50454a406e52a3be67f1ef Signed-off-by: Yi-Hsuan Deng <[email protected]> (cherry picked from commit 3609dac)
pamaury
force-pushed
the
backport_27443
branch
from
c25d2fd to
79ac6a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #27443, depends on #29208, only review the last commit.