Skip to content

Conversation

@vogelpi
Copy link
Contributor

@vogelpi vogelpi commented Feb 6, 2026

This is the 23rd PR of a series of PRs to upstream support for AES-GCM. The original PR can be found here: vogelpi#31


[aes/doc] Document Galois/Counter Mode (GCM) implementation + hardening

Copy link
Member

@nasahlpa nasahlpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, are you planning to also add the SCA analysis to the documentation?

@vogelpi
Copy link
Contributor Author

vogelpi commented Feb 9, 2026

Just out of curiosity, are you planning to also add the SCA analysis to the documentation?

Thanks for the approval. No, I am not planning to add this to the doc. We usually don't provide these results.

@vogelpi
Copy link
Contributor Author

vogelpi commented Feb 9, 2026

CHANGE AUTHORIZED: hw/ip/aes/data/aes.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv

This PR exposes a compile-time Verilog parameter to the top-level such that we can later on disable the hardware GCM support if needed.

@vogelpi vogelpi added the CI:Rerun Rerun failed CI jobs label Feb 9, 2026
@github-actions github-actions bot removed the CI:Rerun Rerun failed CI jobs label Feb 9, 2026
@nasahlpa
Copy link
Member

nasahlpa commented Feb 9, 2026

CHANGE AUTHORIZED: hw/ip/aes/data/aes.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv

This PR exposes a compile-time Verilog parameter to the top-level such that we can later on disable the hardware GCM support if needed.

@vogelpi vogelpi added CI:Rerun Rerun failed CI jobs labels Feb 9, 2026
@github-actions github-actions bot removed the CI:Rerun Rerun failed CI jobs label Feb 9, 2026
@vogelpi vogelpi added the CI:Rerun Rerun failed CI jobs label Feb 9, 2026
@github-actions github-actions bot removed the CI:Rerun Rerun failed CI jobs label Feb 9, 2026
@vogelpi vogelpi added this pull request to the merge queue Feb 9, 2026
Merged via the queue into lowRISC:master with commit 83bdbc6 Feb 9, 2026
51 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants