[spi_device,lint] Fix verilator lint issue #29281
Merged
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TpmRdFifoWidth from spi_device_reg_pkg was imported on L11, then overwritten by a localparam with the same name and value on L87. This commit removes the redundant localparam. Signed-off-by: Ray Lau <[email protected]>
Contributor
|
CHANGE AUTHORIZED: hw/ip/spi_device/rtl/spi_device.sv Clearly no risk to the design: this is just removing a duplicate import! |
hcallahan-lowrisc
approved these changes
Feb 9, 2026
Contributor
hcallahan-lowrisc
left a comment
hcallahan-lowrisc
left a comment
There was a problem hiding this comment.
LGTM, thanks @raylau1 !
Contributor
|
CHANGE AUTHORIZED: hw/ip/spi_device/rtl/spi_device.sv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the verilator VARHIDDEN warning, caused by TpmRdFifoWidth being overwritten on spi_device.sv line 87.