[rv_core_ibex/rtl] Split data and ECC of the register file #29294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasahlpa
requested review from
andreaskurth,
johannheyszl,
marnovandermaas,
rswarbrick,
vogelpi and
zi-v
and removed request for
a team
Update code from upstream repository https://github.com/lowRISC/ibex.git to revision 9f375d7dcb81294300bbe1014042f95a46073d18 * [dv] Adapt the `riscv_rf_intg_test` test (Pascal Nasahl) * [dv] Adapt Ibex RF fault test (Pascal Nasahl) * [rtl] Split data and ECC of the register file (Pascal Nasahl) * [rtl] Remove `WrenCheck` and `RdataMuxCheck` from RF (Pascal Nasahl) Signed-off-by: Pascal Nasahl <[email protected]>
As the register file wren enable check was removed, the assertion `prim_onehot_check` is no longer needed as the `u_prim_onehot_check` instance no longer is in the register file module. Signed-off-by: Pascal Nasahl <[email protected]>
Depending on whether we are faulting the main or the shadow core, use the correct data width size for the register file ports. The main core operates on the plain data (RegFileDataWidth = 32 bit) and the shadow core on the data + ECC (RegFileDataEccWidth = 39 bit). The write data that is forwarded to the shadow core RF only uses the upper bits of the write data. Signed-off-by: Pascal Nasahl <[email protected]>
nasahlpa
force-pushed
the
ibex_rf_split
branch
from
d9a93db to
b27e4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, a single instance of the register file containing 32-bit data words and 7-bit ECC tags was used. While the input of the register file was driven by the main core, the output of the register file was distributed to the main and the shadow core.
In this commit, as approved by this RFC, we are splitting up the data and ECC parts into two different register file instances:
This helps us to save around 6 kGE of area.