[crypto] ML-DSA-87 verify (1/24) #29299
Open
+137
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file documents the high-level implementation choices and should be the initial contact point when navigating to the `mldsa87` directory. Signed-off-by: Andrea Caforio <[email protected]>
Two Bazel build files are required for the ML-DSA-87 apps: One for the sources files and another one for the unit tests. Signed-off-by: Andrea Caforio <[email protected]>
Increase the size of the OTBN DMEM from 4 KiB to 32 KiB (32768 bytes) and the size of the IMEM from 8 KiB to 16 KiB (16384 bytes). Signed-off-by: Andrea Caforio <[email protected]>
andrea-caforio
requested review from
andreaskurth,
etterli,
h-filali,
johannheyszl,
nasahlpa,
siemen11 and
vogelpi
nasahlpa
reviewed
Feb 11, 2026
Comment on lines
+1
to
+3
| /* Copyright lowRISC contributors (OpenTitan project). | ||
| Licensed under the Apache License, Version 2.0, see LICENSE for details. | ||
| SPDX-License-Identifier: Apache-2.0 */ |
Member
There was a problem hiding this comment.
Suggested change
| /* Copyright lowRISC contributors (OpenTitan project). | |
| Licensed under the Apache License, Version 2.0, see LICENSE for details. | |
| SPDX-License-Identifier: Apache-2.0 */ | |
| /* Copyright lowRISC contributors (OpenTitan project). */ | |
| /* Licensed under the Apache License, Version 2.0, see LICENSE for details. */ | |
| /* SPDX-License-Identifier: Apache-2.0 */ |
etterli
reviewed
Feb 11, 2026
Contributor
etterli
left a comment
etterli
left a comment
There was a problem hiding this comment.
Looks good to me except that the memory increase should probably be an atomic commit which also touches the RTL and DV. The reason is that otherwise the DV and potentially IBEX SW breaks.
I think increasing the memories should touch the same files as in this commit: etterli/opentitan-otbn-pqc-isa@b0ce32d
Comment on lines
800
to
801
| Note that DMEM is actually 4kiB in size, but only the first 3kiB of | ||
| the memory is visible through this register interface. |
Contributor
There was a problem hiding this comment.
Suggested change
| TODO: Document the .bss and .scratchpad split | |
| Note that DMEM is actually 32kiB in size, but only the first XkiB of | |
| the memory is visible through this register interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR of the series adding package documentation, Bazel build files and increases the OTBN memories:
This is a series of PRs that in their composition result in FIPS-204-compliant OTBN implementation of ML-DSA-87 verify.
Resources
Preamble
docNumber-theoretic transform
NTTINTTPolynomial arithmetic
poly_add,poly_sub,poly_mulpoly_mul_addXOF
xof_init,xof_poll,xof_finishxof_absorbxof_squeezeRounding
shift_leftdecomposeReduction
reduceInfinity norm
norm_checkSampling
rej_ntt_poly,expand_asample_in-ballchallenge_hashEncoding
decode_zdecode_t1decode_hintencode_w1Vector operations
sig_decodenorm_check_zA*z,c * t1,Az - ct1use_hintEpilogue
app