[rom_ext] Add bl0 boot diagnostics to boot_log#30373
Open
cfrantz wants to merge 1 commit into
Open
Conversation
cfrantz
force-pushed
the
more_boot_log
branch
2 times, most recently
from
7cee181 to
0489875
Compare
This commit: - Fixes the static assertions in boot_log.h to match the new layout. - Updates boot_log_unittest.cc to initialize and verify all fields of boot_log_t using memcmp. - Updates the E2E test position_owner_slot_b to verify that bl0_failure_reason is correctly populated. - Commits the previous changes to boot_log.h, rom_ext.c, boot_test.c, and boot_log.rs that added the bl0_firmware_domain and bl0_failure_reason fields. TAG=agy CONV=add60186-d4ca-48b7-b9b8-d777ef5b71f4 Signed-off-by: Chris Frantz <cfrantz@google.com>
moidx
approved these changes
Jun 13, 2026
| return kErrorRomExtBootFailed; | ||
| } | ||
| const owner_application_key_t *key = keyring.key[verify_key]; | ||
| boot_log->bl0_firmware_domain = key->key_domain; |
Contributor
There was a problem hiding this comment.
Should bl0_firmware_domain be initialized?
| } | ||
| const owner_application_key_t *key = keyring.key[verify_key]; | ||
| boot_log->bl0_firmware_domain = key->key_domain; | ||
| boot_log_digest_update(boot_log); |
Contributor
There was a problem hiding this comment.
Would it make sense to update the digest whenever the bl0_failure_reason is updated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit:
TAG=agy
CONV=add60186-d4ca-48b7-b9b8-d777ef5b71f4