[kmac,dv] Pass req/rsp to kmac_app_if through inout ports#30395
Draft
rswarbrick wants to merge 3 commits into
Draft
[kmac,dv] Pass req/rsp to kmac_app_if through inout ports#30395rswarbrick wants to merge 3 commits into
rswarbrick wants to merge 3 commits into
Conversation
There's no need to encode the name of the environment into agents that it instantiates. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
No functional change, but this matches the conventional name used in OpenTitan for interfaces. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
This should be a little cleaner than the version we were using before. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in draft because it depends on:
Once these two are merged, only a single commit remains, with the following commit message: