Skip to content

Conversation

@helgee
Copy link
Member

@helgee helgee commented Oct 17, 2025

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 74.84277% with 240 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.34%. Comparing base (c751987) to head (2496fc0).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
crates/lox-units/src/units.rs 47.39% 121 Missing ⚠️
crates/lox-earth/src/itrf.rs 0.00% 35 Missing ⚠️
crates/lox-units/src/coords.rs 79.38% 20 Missing ⚠️
crates/lox-frames/src/dynamic.rs 40.90% 13 Missing ⚠️
crates/lox-space/src/orbits/python.rs 0.00% 11 Missing ⚠️
crates/lox-frames/src/transformations/rotations.rs 0.00% 9 Missing ⚠️
crates/lox-space/src/units/python.rs 0.00% 7 Missing ⚠️
crates/lox-earth/src/eop.rs 28.57% 5 Missing ⚠️
crates/lox-frames/src/frames.rs 72.22% 5 Missing ⚠️
crates/lox-space/src/frames/python.rs 0.00% 5 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   69.47%   69.34%   -0.14%     
==========================================
  Files          89       89              
  Lines       21007    21247     +240     
==========================================
+ Hits        14595    14734     +139     
- Misses       6412     6513     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 17, 2025

CodSpeed Performance Report

Merging #257 will not alter performance

Comparing he/frames-refactor (2496fc0) with main (c751987)

Summary

✅ 3 untouched
⏩ 1 skipped1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

Copy link
Member Author

@helgee helgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the groundwork for actually implementing the frame transformations properly.

@helgee helgee force-pushed the he/frames-refactor branch 2 times, most recently from 3e3f1aa to 5c5e9cc Compare October 17, 2025 20:47
@helgee helgee force-pushed the he/frames-refactor branch from 5c5e9cc to 017921f Compare October 17, 2025 20:56
@helgee helgee force-pushed the he/frames-refactor branch from f40db46 to 432a609 Compare October 18, 2025 22:08
@helgee helgee force-pushed the he/frames-refactor branch from 432a609 to 759bd14 Compare October 18, 2025 22:10
@helgee helgee force-pushed the he/frames-refactor branch from 3fdafd9 to 2496fc0 Compare October 20, 2025 11:41
@helgee helgee marked this pull request as ready for review October 20, 2025 11:47
@helgee helgee merged commit 5fd874a into main Oct 20, 2025
22 checks passed
@helgee helgee deleted the he/frames-refactor branch October 20, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants