Skip to content

Conversation

@helgee
Copy link
Member

@helgee helgee commented Oct 20, 2025

There was a yak that needed shaving...

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 95.66038% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.71%. Comparing base (5fd874a) to head (4cb50c1).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/lox-test-utils/src/approx_eq/results.rs 77.31% 22 Missing ⚠️
crates/lox-bodies/src/lib.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   69.34%   68.71%   -0.64%     
==========================================
  Files          89       90       +1     
  Lines       21247    21461     +214     
==========================================
+ Hits        14734    14747      +13     
- Misses       6513     6714     +201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #258 will not alter performance

Comparing he/approx-eq (4cb50c1) with main (5fd874a)

Summary

✅ 3 untouched
⏩ 1 skipped1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@helgee helgee force-pushed the he/approx-eq branch 4 times, most recently from 09a1449 to f80229b Compare October 20, 2025 23:06
@helgee helgee force-pushed the he/approx-eq branch 3 times, most recently from 1093943 to 5a41f3a Compare October 21, 2025 10:43
@helgee helgee merged commit c2363f7 into main Oct 21, 2025
20 of 21 checks passed
@helgee helgee deleted the he/approx-eq branch October 21, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants