Dedicated column for target time prefix#95
Open
PrinterElf wants to merge 3 commits intolozzd:mainfrom
Open
Conversation
Add a new column to the left of the timestamp to hold the prefix for any target time entries. Ensures that the times still remain aligned when there's a target time.
lozzd
reviewed
Jul 18, 2025
octopus-energy-rates-card.js
Outdated
|
|
||
| if (showpast || (date - Date.parse(new Date()) > -1800000)) { | ||
| table = table.concat("<tr class='rate_row'><td class='time " + boldStyle + " " + "time_" + colour + targetTimeBackgroundColor + "'>" + targetTimePrefix + date_locale + time_locale + | ||
| table = table.concat("<tr class='rate_row'><td class='target " + "time_" + colour + targetTimeBackgroundColor + "'>" + targetTimePrefix + "<td class='time " + boldStyle + " " + "time_" + colour + targetTimeBackgroundColor + "'>" + date_locale + time_locale + |
Owner
There was a problem hiding this comment.
This line is getting a bit unwieldy - you commented out the section that forms this string targetTimePrefix above, does that still work proprely? can it be re-used to make this a bit shorter? Thanks!
Author
There was a problem hiding this comment.
Sorry, totally missed the notification for this.
I suppose it could be; build the three cells separately (prefix, time, and rate) then just concatenate the variables.
Plus I've just realised I didn't close off the cell I added, so there's a missing "</td>" just before the second "<td class="
Updated the table row printing line to use individual variables for each column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new column to the left of the timestamp to hold the prefix for any target time entries. Ensures that the times still remain aligned when there's a target time.