Migrate I2C to embedded-hal 1.0#85
Merged
sosthene-nitrokey merged 1 commit intoembedded-hal-10from Sep 24, 2025
Merged
Conversation
sosthene-nitrokey
force-pushed
the
embedded-hal-10
branch
from
906a423 to
4fb5f10
Compare
sosthene-nitrokey
force-pushed
the
i2c-embedded-hal-10
branch
from
461184b to
d013213
Compare
sosthene-nitrokey
force-pushed
the
i2c-embedded-hal-10
branch
from
d013213 to
d9a9c85
Compare
Contributor
robin-nitrokey
left a comment
robin-nitrokey
left a comment
There was a problem hiding this comment.
Oh, I forgot to publish the question I had for this PR.
| address: u8, | ||
| operations: &mut [embedded_hal::i2c::Operation<'_>], | ||
| ) -> core::result::Result<(), Self::Error> { | ||
| let [ref mut current, ref mut rem @ ..] = operations else { |
Contributor
There was a problem hiding this comment.
What’s the advantage of this syntax over split_first_mut?
Contributor
Author
There was a problem hiding this comment.
None, I tend to use it because split_first_mut isn't really on my mind. split_first_mut is better readable though. I'll move to it.
Contributor
Author
|
Initially I wanted to review each individually but fixing the examples was hard with the stacked PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps support for embedded-hal 0.2.7 but builds it on top of the implementation for embedded-hal 1.0