Add max_requests client option - #143
Merged
Merged
Conversation
Limit the number of requests a connection handles before it is recycled. When the cap is reached the server is disabled in the pool so no new requests are routed to it, in-flight requests drain normally, then the socket is closed and reconnected immediately. Reconnecting re-resolves DNS, which allows periodic rebalancing across DNS-based load balancers. Defaults to infinity, preserving existing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
max_requestsclient option (pos_integer() | infinity, defaultinfinity) that limits how many requests a connection handles before it is recycled, as requested in #69.When the cap is reached, the server is disabled in the pool so no new requests are routed to it, in-flight requests drain normally, then the socket is closed and reconnected immediately (skipping the reconnect backoff, since the connection was healthy). Reconnecting goes through
inet:getaddrs/2, so DNS is re-resolved on every recycle — enabling periodic rebalancing across DNS-based load balancers.requests_leftis reset on every successful connect; error-driven reconnects are unaffected.max_requestscalls while requests keep succeeding.Closes #69