Skip to content

fix(security): do not enforce security when no @Policy annotation is present #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SedaOran wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): do not enforce security when no @Policy annotation is present #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions src/main/java/de/tum/cit/ase/ares/api/jupiter/JupiterSecurityExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ public final class JupiterSecurityExtension
*/
@Override
public void beforeTestExecution(ExtensionContext extensionContext) throws Exception {
System.err.println("[ARES-LIFECYCLE] beforeTestExecution called");
resetSettingsInStandardClassLoader();
resetSettingsInBootstrapClassLoader();

Expand All @@ -46,20 +45,14 @@ public void beforeTestExecution(ExtensionContext extensionContext) throws Except
Optional<Policy> policyOpt = methodPolicy.or(() -> classPolicy);
boolean hasPolicyAnnotation = policyOpt.isPresent();
boolean isAresActivated = policyOpt.map(Policy::activated).orElse(true);
boolean isTestMethodPresent = testContext.testMethod().isPresent();
System.err.println("[ARES-LIFECYCLE] hasPolicyAnnotation=" + hasPolicyAnnotation + " isAresActivated="
+ isAresActivated + " isTestMethodPresent=" + isTestMethodPresent);

if (isAresActivated && (hasPolicyAnnotation || isTestMethodPresent)) {
if (isAresActivated && hasPolicyAnnotation) {
Path policyPath = policyOpt.filter(p -> !p.value().isBlank())
.map(JupiterSecurityExtension::testAndGetPolicyValue).orElse(null);
Path withinPath = policyOpt.filter(p -> !p.withinPath().isBlank())
.map(JupiterSecurityExtension::testAndGetPolicyWithinPath).orElse(Path.of(""));
System.err
.println("[ARES-LIFECYCLE] executing with policyPath=" + policyPath + " withinPath=" + withinPath);
SecurityPolicyReaderAndDirector.builder().securityPolicyFilePath(policyPath).projectFolderPath(withinPath)
.build().createTestCases().executeTestCases();
System.err.println("[ARES-LIFECYCLE] executeTestCases completed");
}
}

Expand Down Expand Up @@ -92,14 +85,11 @@ public <T> T interceptGenericInvocation(Invocation<T> invocation, ExtensionConte
resetSettingsInStandardClassLoader();
resetSettingsInBootstrapClassLoader();

// Determine security enforcement:
// - @Policy(activated=true) → enforce with custom policy from file
// - no @Policy on @Test method → enforce with default policy (null path)
// - @Policy(activated=false) → Ares deactivated (no security checks)
// Skip enforcement during constructor interception (no test method present
// yet).
boolean isTestMethodPresent = testContext.testMethod().isPresent();
if (isAresActivated && (hasPolicyAnnotation || isTestMethodPresent)) {
// Enforce security only when an explicit @Policy annotation is present.
// Without a @Policy the restricted-package scanner returns "" which would
// match every class name and block Ares/JUnit internals, causing
// SecurityExceptions in trivial tests that have no policy at all.
if (isAresActivated && hasPolicyAnnotation) {
Path policyPath = policyOpt.filter(p -> !p.value().isBlank())
.map(JupiterSecurityExtension::testAndGetPolicyValue).orElse(null);
Path withinPath = policyOpt.filter(p -> !p.withinPath().isBlank())
Expand Down
Loading