`Exam mode`: Migrate participate module to signals #10456

coolchock · 2025-03-09T19:33:22Z

Checklist

General

I tested all changes and their related features with all corresponding user types on a test server.
I chose a title conforming to the naming conventions for pull requests.

Client

I strictly followed the client coding and design guidelines.

Motivation and Context

Description

This is the final pull request that completes the migration of the exam mode to use signals.

Steps for Testing

Prerequisites:

1 Instructor
1 Student
1 Exam and 1 Test Exam with all exercise types

Log in to Artemis.
Participate in both the Exam and the Test Exam multiple times (Test Exams now support multiple attempts).
Verify the following:
- Exam navigation bar works as expected
- Exam start page works as expected
- Exam cover page works as expected
- Exam summary page works as expected
- Participating in the exercises does not cause any issues

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Performance Review

I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

Code Review 1
Code Review 2

Manual Tests

Test 1
Test 2

Summary by CodeRabbit

Refactor
- Enhanced exam interfaces by streamlining dynamic data updates across exam overview, timer, navigation, and result summary displays. This ensures that exam statuses, timings, and progress are more consistently and accurately reflected, providing a smoother user experience.
Tests
- Updated test suites to verify the improved responsiveness and reliability of exam components, ensuring consistent behavior during exam sessions.

…e-to-signals

github-actions · 2025-04-22T17:28:47Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	201 ran	196 passed	3 skipped	2 failed	50m 23s 164ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/course/CourseMessages.spec.ts
ts.Course messages › Channel messages › Write/edit/delete message in channel › Student should be able to edit message in channel	❌ failure	2m 2s 775ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	1m 45s 822ms

github-actions · 2025-04-22T18:58:22Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	201 ran	196 passed	3 skipped	2 failed	51m 32s 267ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/course/CourseMessages.spec.ts
ts.Course messages › Channel messages › Write/edit/delete message in channel › Student should be able to edit message in channel	❌ failure	2m 2s 935ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	1m 46s 40ms

HawKhiem

Tested on TS3. Everything went smoothly in the first attempt of an exam. I noticed something odd when attempting an exam the second time. I couldn't submit the programming exercise, I either had a 404 or 500 error. The same thing happened for follow up attempts.

Also the number of attempts is not updated correctly. I have made 2 attempts but the attempts count is still 0.

florian-glombik

Please fix the outcommented code in src/main/webapp/app/exam/overview/exam-cover/exam-participation-cover.component.spec.ts - I think it can be removed?

Could we also align the usage of update vs set?
https://angular.dev/guide/signals#writable-signals

Besides that the changes look fine to me

src/main/webapp/app/exam/overview/events/button/exam-live-events-button.component.ts

src/main/webapp/app/exam/overview/events/overlay/exam-live-events-overlay.component.ts

src/main/webapp/app/exam/overview/exam-cover/exam-participation-cover.component.spec.ts

src/main/webapp/app/exam/overview/exam-navigation-sidebar/exam-navigation-sidebar.component.ts

src/main/webapp/app/exam/overview/exam-navigation-bar/exam-navigation-bar.component.ts

src/main/webapp/app/exam/overview/events/button/exam-live-events-button.component.ts

florian-glombik · 2025-04-25T10:18:37Z

...ain/webapp/app/exam/overview/exam-start-information/exam-start-information.component.spec.ts

+        TestBed.runInInjectionContext(() => {
+            component.exam = input(exam);
+            component.studentExam = input(studentExam);
+        });


Why don't we do this in the @beforeEach?

...main/webapp/app/exam/overview/general-information/exam-general-information.component.spec.ts

github-actions · 2025-04-26T08:29:06Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	201 ran	197 passed	3 skipped	1 failed	49m 27s 49ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/course/CourseMessages.spec.ts
ts.Course messages › Channel messages › Write/edit/delete message in channel › Student should be able to edit message in channel	❌ failure	2m 3s 124ms

florian-glombik

Approve code

There are still two outcommented lines of code, but no dealbreaker

src/main/webapp/app/exam/overview/exam-cover/exam-participation-cover.component.spec.ts

florian-glombik

Thanks for the adjustments, the code looks good to me! 😄

github-actions · 2025-04-28T10:05:30Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	201 ran	197 passed	3 skipped	1 failed	44m 52s 80ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/course/CourseMessages.spec.ts
ts.Course messages › Channel messages › Write/edit/delete message in channel › Student should be able to edit message in channel	❌ failure	2m 3s 411ms

HawKhiem

Retested on TS3. Everything mentioned works as it should. There is still the problem I mentioned earlier, but that probably has nothing to do with this PR. Should I create an issue for this?

coolchock added 26 commits March 6, 2025 23:30

migrate exam-bar.component

6283c32

migrate exam-timer.component

04002c5

migrate text-exam-summary.component

cad80ac

migrate quiz-exam-summary.component

3dbfef9

migrate programming-exam-summary.component

d2f2efc

migrate exam-result-overview.component

442a149

migrate modeling-exam-summary.component

7b9da2d

exam-result-summary-exercise-card-header.component

db297ab

migate file-upload-exam-summary.component

203be39

migrate exam-start-information.component

714f6b6

migrate exam-general-information.component

0a051bf

fix exam-result-summary-exercise-card-header.component.spec.ts

8a4cf74

fix exam-start-information.component.spec.ts

bee2026

fix exam-general-information.component.spec.ts

277edeb

fix quiz-exam-summary.component.spec.ts

8431840

fix programming-exam-summary.component.spec.ts

78f6cc7

fix exam-result-overview.component.spec.ts

5ba33b0

fix file-upload-exam-summary.component.spec.ts

08a6b7c

fix modeling-exam-summary.component.spec.ts

62daa58

migrate exam-participation.component.ts

402136d

migrate exam-navigation-bar.component

47a5ef6

migrate exam-navigation-bar.component

cd3983d

set default value

605f5c0

migrate exam-participation-cover.component

21f9921

migrate collapsible-card.component

1025b43

migrate overlay and button for live events

c288d30

github-project-automation bot moved this to Work In Progress in Artemis Development Mar 9, 2025

github-project-automation bot added this to Artemis Development Mar 9, 2025

github-actions bot assigned coolchock Mar 9, 2025

github-actions bot added the tests label Mar 9, 2025

coolchock removed the stale label Apr 21, 2025

coolchock added 3 commits April 22, 2025 18:40

fix programming-exam-summary.component.spec.ts

7697664

Merge branch 'develop' into chore/exam-mode/migrate-participate-modul…

a190dcf

…e-to-signals

Merge branch 'develop' into chore/exam-mode/migrate-participate-modul…

64864be

…e-to-signals

coolchock added the ready for review label Apr 24, 2025

helios-aet bot temporarily deployed to artemis-test3.artemis.cit.tum.de April 25, 2025 06:56 Inactive

HawKhiem reviewed Apr 25, 2025

View reviewed changes

florian-glombik requested changes Apr 25, 2025

View reviewed changes

github-project-automation bot moved this from Work In Progress to Ready For Review in Artemis Development Apr 25, 2025

coolchock added 8 commits April 25, 2025 17:56

move inputs setup to beforeEach

5cbd213

remove commented code

10fe5e8

use set instead of update

5171eb3

remove redundant element

4589cf6

make input parameter required

d693002

make modal required

52baf3b

remove unused import

40bbfdf

move input setup to beforeEach

b80c1d2

coderabbitai bot previously approved these changes Apr 28, 2025

View reviewed changes

florian-glombik previously approved these changes Apr 28, 2025

View reviewed changes

src/main/webapp/app/exam/overview/exam-cover/exam-participation-cover.component.spec.ts Outdated Show resolved Hide resolved

src/main/webapp/app/exam/overview/exam-cover/exam-participation-cover.component.spec.ts Outdated Show resolved Hide resolved

remove uncommented code

5ec982c

coolchock dismissed stale reviews from florian-glombik and coderabbitai[bot] via 5ec982c April 28, 2025 09:24

coderabbitai bot approved these changes Apr 28, 2025

View reviewed changes

florian-glombik approved these changes Apr 28, 2025

View reviewed changes

helios-aet bot temporarily deployed to artemis-test3.artemis.cit.tum.de April 30, 2025 06:39 Inactive

HawKhiem approved these changes Apr 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Exam mode`: Migrate participate module to signals #10456

`Exam mode`: Migrate participate module to signals #10456

coolchock commented Mar 9, 2025 •

edited by HawKhiem

Loading

github-actions bot commented Apr 22, 2025

github-actions bot commented Apr 22, 2025

HawKhiem left a comment

florian-glombik left a comment

florian-glombik Apr 25, 2025

coolchock Apr 26, 2025

github-actions bot commented Apr 26, 2025

florian-glombik left a comment

florian-glombik left a comment

github-actions bot commented Apr 28, 2025

HawKhiem left a comment

Exam mode: Migrate participate module to signals #10456

Are you sure you want to change the base?

Exam mode: Migrate participate module to signals #10456

Conversation

coolchock commented Mar 9, 2025 • edited by HawKhiem Loading

Checklist

General

Client

Motivation and Context

Description

Steps for Testing

Testserver States

Review Progress

Performance Review

Code Review

Manual Tests

Summary by CodeRabbit

github-actions bot commented Apr 22, 2025

End-to-End (E2E) Test Results Summary

github-actions bot commented Apr 22, 2025

End-to-End (E2E) Test Results Summary

HawKhiem left a comment

Choose a reason for hiding this comment

florian-glombik left a comment

Choose a reason for hiding this comment

florian-glombik Apr 25, 2025

Choose a reason for hiding this comment

coolchock Apr 26, 2025

Choose a reason for hiding this comment

github-actions bot commented Apr 26, 2025

End-to-End (E2E) Test Results Summary

florian-glombik left a comment

Choose a reason for hiding this comment

florian-glombik left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 28, 2025

End-to-End (E2E) Test Results Summary

HawKhiem left a comment

Choose a reason for hiding this comment

`Exam mode`: Migrate participate module to signals #10456

`Exam mode`: Migrate participate module to signals #10456

coolchock commented Mar 9, 2025 •

edited by HawKhiem

Loading