Skip to content

Exam mode: Migrate participate module to signals #10456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 80 commits into
base: develop
Choose a base branch
from

Conversation

coolchock
Copy link
Contributor

@coolchock coolchock commented Mar 9, 2025

Checklist

General

Client

Motivation and Context

Description

This is the final pull request that completes the migration of the exam mode to use signals.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Student
  • 1 Exam and 1 Test Exam with all exercise types
  1. Log in to Artemis.
  2. Participate in both the Exam and the Test Exam multiple times (Test Exams now support multiple attempts).
  3. Verify the following:
    • Exam navigation bar works as expected
    • Exam start page works as expected
    • Exam cover page works as expected
    • Exam summary page works as expected
    • Participating in the exercises does not cause any issues

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Summary by CodeRabbit

  • Refactor

    • Enhanced exam interfaces by streamlining dynamic data updates across exam overview, timer, navigation, and result summary displays. This ensures that exam statuses, timings, and progress are more consistently and accurately reflected, providing a smoother user experience.
  • Tests

    • Updated test suites to verify the improved responsiveness and reliability of exam components, ensuring consistent behavior during exam sessions.

coderabbitai[bot]
coderabbitai bot previously approved these changes May 11, 2025
Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ✅Skipped ⚠️FailedTime ⏱
End-to-End (E2E) Test Report201 ran198 passed3 skipped0 failed51m 57s 724ms
TestResultTime ⏱
No test annotations available

Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ✅Skipped ⚠️FailedTime ⏱
End-to-End (E2E) Test Report201 ran198 passed3 skipped0 failed51m 41s 164ms
TestResultTime ⏱
No test annotations available

…e-to-signals

# Conflicts:
#	src/main/webapp/app/exam/manage/students/upload-images/students-upload-images-button.component.spec.ts
Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ✅Skipped ⚠️FailedTime ⏱
End-to-End (E2E) Test Report201 ran198 passed3 skipped0 failed51m 2s 570ms
TestResultTime ⏱
No test annotations available

Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report201 ran197 passed3 skipped1 failed56m 9s 453ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors❌ failure1m 48s 98ms

Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report201 ran196 passed3 skipped2 failed57m 33s 470ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseParticipation.spec.ts
ts.Quiz Exercise Participation › DnD Quiz participation › Student can participate in DnD Quiz❌ failure2m 3s 760ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors❌ failure1m 48s 369ms

Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report201 ran197 passed3 skipped1 failed55m 19s 497ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors❌ failure1m 46s 194ms

Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report201 ran197 passed3 skipped1 failed56m 51s 292ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors❌ failure1m 48s 10ms

Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ✅Skipped ⚠️FailedTime ⏱
End-to-End (E2E) Test Report201 ran198 passed3 skipped0 failed53m 18s 791ms
TestResultTime ⏱
No test annotations available

coolchock added 2 commits June 7, 2025 18:31
…e-to-signals

# Conflicts:
#	src/main/webapp/app/exam/overview/summary/exercises/programming-exam-summary/programming-exam-summary.component.html
#	src/main/webapp/app/exam/overview/summary/exercises/programming-exam-summary/programming-exam-summary.component.spec.ts
#	src/main/webapp/app/exam/overview/summary/exercises/programming-exam-summary/programming-exam-summary.component.ts
#	src/main/webapp/app/exam/overview/summary/exercises/quiz-exam-summary/quiz-exam-summary.component.ts
#	src/main/webapp/app/exam/overview/summary/result-overview/exam-result-overview.component.ts
Copy link

github-actions bot commented Jun 7, 2025

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report201 ran197 passed3 skipped1 failed57m 59s 90ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors❌ failure2m 10s 574ms

Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

…e-to-signals

# Conflicts:
#	src/main/webapp/app/exam/manage/students/upload-images/students-upload-images-button.component.spec.ts
#	src/main/webapp/app/exam/manage/students/upload-images/students-upload-images-dialog.component.spec.ts
#	src/main/webapp/app/exam/overview/summary/exercises/header/exam-result-summary-exercise-card-header.component.html
#	src/main/webapp/app/exam/overview/summary/exercises/header/exam-result-summary-exercise-card-header.component.spec.ts
#	src/main/webapp/app/exam/overview/summary/exercises/header/exam-result-summary-exercise-card-header.component.ts
Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report201 ran195 passed3 skipped3 failed1h 1m 21s 100ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exam/ExamDateVerification.spec.ts
ts.Exam date verification › Exam timing › Student can start after start Date❌ failure2m 4s 898ms
e2e/exercise/programming/ProgrammingExerciseParticipation.spec.ts
ts.Programming exercise participation › Programming exercise team participation › Team members make git submissions❌ failure49s 557ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors❌ failure2m 12s 143ms

Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report201 ran197 passed3 skipped1 failed51m 27s 58ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exercise/programming/ProgrammingExerciseParticipation.spec.ts
ts.Programming exercise participation › Programming exercise team participation › Team members make git submissions❌ failure36s 811ms

@github-actions github-actions bot removed the stale label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) exam Pull requests that affect the corresponding module
Projects
Status: Ready For Review
Development

Successfully merging this pull request may close these issues.

5 participants