You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added multiple integration tests (Spring) related to the features (with a high test coverage).
I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
I documented the Java code using JavaDoc style.
Client
Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
I strictly followed the principle of data economy for all client-server REST calls.
Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
I documented the TypeScript code using JSDoc style.
I added multiple screenshots/screencasts of my UI changes.
I translated all newly inserted strings into English and German.
Motivation and Context
In particular for local development, we want to allow disabling certain modules like the lecture module in this PR.
Description
Make Spring components in the lecture-module be autowired based on the value of a custom property, instead of the generic PROFILE_CORE.
This also includes client changes to reflect this.
Disclaimer: Because this is mainly intended to be used for local development, there might be edge cases that cause issues.
Steps for Testing
Note: Needs local testing.
Set artemis.lecture.enabled=false in your application-local.yml
Open the course management overview. See that the lecture button is disabled (S1)
Go to one course and ensure that the lecture button in the tab bar is disabled (S2)
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
github-actionsbot
added
tests
server
Pull requests that update Java code. (Added Automatically!)
client
Pull requests that update TypeScript code. (Added Automatically!)
config-change
Pull requests that change the config in a way that they require a deployment via Ansible.
atlas
Pull requests that affect the corresponding module
communication
Pull requests that affect the corresponding module
core
Pull requests that affect the corresponding module
exercise
Pull requests that affect the corresponding module
iris
Pull requests that affect the corresponding module
lecture
Pull requests that affect the corresponding module
lti
Pull requests that affect the corresponding module
plagiarism
Pull requests that affect the corresponding module
labels
Apr 7, 2025
github-actionsbot
removed
atlas
Pull requests that affect the corresponding module
communication
Pull requests that affect the corresponding module
exercise
Pull requests that affect the corresponding module
iris
Pull requests that affect the corresponding module
labels
Apr 7, 2025
github-actionsbot
added
quiz
Pull requests that affect the corresponding module
text
Pull requests that affect the corresponding module
tutorialgroup
Pull requests that affect the corresponding module
labels
Apr 7, 2025
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.
github-actionsbot
removed
playwright
assessment
Pull requests that affect the corresponding module
atlas
Pull requests that affect the corresponding module
buildagent
Pull requests that affect the corresponding module
communication
Pull requests that affect the corresponding module
exam
Pull requests that affect the corresponding module
exercise
Pull requests that affect the corresponding module
fileupload
Pull requests that affect the corresponding module
iris
Pull requests that affect the corresponding module
lti
Pull requests that affect the corresponding module
modeling
Pull requests that affect the corresponding module
plagiarism
Pull requests that affect the corresponding module
programming
Pull requests that affect the corresponding module
quiz
Pull requests that affect the corresponding module
text
Pull requests that affect the corresponding module
tutorialgroup
Pull requests that affect the corresponding module
labels
Apr 28, 2025
clientPull requests that update TypeScript code. (Added Automatically!)config-changePull requests that change the config in a way that they require a deployment via Ansible.corePull requests that affect the corresponding modulelecturePull requests that affect the corresponding moduleserverPull requests that update Java code. (Added Automatically!)staletests
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
In particular for local development, we want to allow disabling certain modules like the lecture module in this PR.
Description
Make Spring components in the lecture-module be autowired based on the value of a custom property, instead of the generic
PROFILE_CORE
.This also includes client changes to reflect this.
Disclaimer
: Because this is mainly intended to be used for local development, there might be edge cases that cause issues.Steps for Testing
Note
: Needs local testing.artemis.lecture.enabled=false
in yourapplication-local.yml
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Screenshots
S1: Management Course Card View

S2: Management Tab Card View
