Development: Allow disabling lecture module in server and client
#10652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of generic "PROFILE_CORE"
github-actions
bot
added
tests
server
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||||||||||||||||||||
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||||||||||||||||||||
tobias-lippert
requested changes
May 6, 2025
|
|
||
| /** | ||
| * Condition to check if the Lecture module is enabled. | ||
| * Based on this condition, Spring components concerning atlas functionality can be enabled or disabled. |
There was a problem hiding this comment.
Suggested change
| * Based on this condition, Spring components concerning atlas functionality can be enabled or disabled. | |
| * Based on this condition, Spring components concerning lecture functionality can be enabled or disabled. |
| <span class="d-none d-xl-inline" jhiTranslate="entity.action.lecture"></span> | ||
| </a> | ||
| <jhi-feature-overlay [enabled]="lectureEnabled"> | ||
| <a |
There was a problem hiding this comment.
i think this is inconsistent now. We hide it in the sidebar, but it's greyed out on the course card.
| @@ -13,10 +13,12 @@ | |||
| <span class="tab-link-text" jhiTranslate="artemisApp.courseOverview.menu.exercises"></span> | |||
| </a> | |||
| @if (course.isAtLeastEditor) { | |||
| <a class="tab-link" [routerLink]="['/course-management', course.id, 'lectures']" id="lectures" routerLinkActive="active"> | |||
| <fa-icon [icon]="faFilePdf" /> | |||
| <span class="tab-link-text" jhiTranslate="artemisApp.courseOverview.menu.lectures"></span> | |||
There was a problem hiding this comment.
this component is unused afaik
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||||||||||||||||||||
florian-glombik
requested changes
May 8, 2025
There was a problem hiding this comment.
The server does now start locally with artemis.lecture.enabled:false
Add Lectureshould not be displayed (or enabled)
-
Also, shouldn't we disable the lecture related routes in the client?
If I press on theAdd Lecturebutton in the quick actions I am forwarded to the page http://localhost:9000/course-management/21/lectures/new - I would have expected that the router returns a page not found. -
There are errors thrown in the competency section when adding / editing new competencies, this should not be the case
http://localhost:9000/course-management/21/competency-management/1/edit
Request URL:
http://localhost:9000/api/lecture/courses/21/lectures?withLectureUnits=1
Request Method:
GET
Status Code:
Screen.Recording.2025-05-08.at.12.05.37.mov
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||
HawKhiem
requested changes
May 8, 2025
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
github-project-automation
bot
moved this from Ready For Review
to Work In Progress
in Artemis Development
|
@ole-ve please finish this PR asap |
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Client
authoritiesto all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
In particular for local development, we want to allow disabling certain modules like the lecture module in this PR.
Description
Make Spring components in the lecture-module be autowired based on the value of a custom property, instead of the generic
PROFILE_CORE.This also includes client changes to reflect this.
Disclaimer: Because this is mainly intended to be used for local development, there might be edge cases that cause issues.Steps for Testing
Note: Needs local testing.artemis.lecture.enabled=falsein yourapplication-local.ymlTestserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Screenshots
S1: Management Course Card View
S2: Management Tab Card View
Summary by CodeRabbit