Development: Use existing builds for protected branches and improve PR lookup to avoid forked PR interference
#10719
+46
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egekocabas
temporarily deployed
to
artemis-test1.artemis.cit.tum.de
GitHub Actions
Inactive
egekocabas
temporarily deployed
to
artemis-test7.artemis.cit.tum.de
GitHub Actions
Inactive
egekocabas
changed the title
Development: Ignore forked PRs and skip rebuilds for protected branches during deployment
egekocabas
changed the title
Development: Ignore forked PRs and skip rebuilds for protected branches during deploymentDevelopment: Skip redundant builds for protected branches and ignore forked PRs
egekocabas
changed the title
Development: Skip redundant builds for protected branches and ignore forked PRsDevelopment: Use existing builds for protected branches and improve PR lookup to avoid forked PR interference
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Our previous deployment logic had two key issues:
When deploying protected branches like
developormain, which rely on thepushevent to triggerbuild.yml, we unnecessarily triggered a new build even when a successful one already existed. This led to wasted CI resources and longer deployment times.When attempting to deploy a branch (e.g.,
develop), the workflow searched for any open PRs targetingdevelop. If a user had opened a PR from a fork (e.g., their forked repo’sdevelopbranch), it matched the search query, leading to misaligned deployment behavior.This PR addresses both issues by:
Description
develop,main), skipping unnecessary rebuilds.Example Runs
developbranch deployment: https://github.com/ls1intum/Artemis/actions/runs/14591912614