-
Notifications
You must be signed in to change notification settings - Fork 322
Development
: Use existing builds for protected branches and improve PR lookup to avoid forked PR interference
#10719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Development
: Ignore forked PRs and skip rebuilds for protected branches during deployment
Development
: Ignore forked PRs and skip rebuilds for protected branches during deploymentDevelopment
: Skip redundant builds for protected branches and ignore forked PRs
Development
: Skip redundant builds for protected branches and ignore forked PRsDevelopment
: Use existing builds for protected branches and improve PR lookup to avoid forked PR interference
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
@Hialus @bensofficial Can you take a look at this? |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
Hello @Hialus, could you also take a look at and also maybe run some deployments to test the functionality? |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
@Hialus could you please take a look at this PR? |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
Hey @Hialus do you have a time to check the latest changes? |
749be91
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look sound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look sound.
Motivation and Context
Our previous deployment logic had two key issues:
When deploying protected branches like
develop
ormain
, which rely on thepush
event to triggerbuild.yml
, we unnecessarily triggered a new build even when a successful one already existed. This led to wasted CI resources and longer deployment times.When attempting to deploy a branch (e.g.,
develop
), the workflow searched for any open PRs targetingdevelop
. If a user had opened a PR from a fork (e.g., their forked repo’sdevelop
branch), it matched the search query, leading to misaligned deployment behavior.This PR addresses both issues by:
Description
develop
,main
), skipping unnecessary rebuilds.Example Runs
develop
branch deployment: https://github.com/ls1intum/Artemis/actions/runs/14591912614