`Communication`: Add send as regular message option for replies #10739

asliayk · 2025-04-24T21:20:45Z

Checklist

General

I tested all changes and their related features with all corresponding user types on a test server.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the principle of data economy for all database calls.
I strictly followed the server coding and design guidelines.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
I strictly followed the principle of data economy for all client-server REST calls.
I strictly followed the client coding and design guidelines.
I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
I added multiple screenshots/screencasts of my UI changes.
I translated all newly inserted strings into English and German.

Motivation and Context

Currently, when replying to a message, the response is always created as an AnswerPost. However, there is no option to post the reply as a regular Post instead. This limitation is not always ideal in scenarios where the reply is relevant to the entire conversation rather than just being tied to the original message.

Description

This PR introduces "Also send as direct message" option when writing a reply.

A checkbox has been added below the input field for replies.
When selected, the reply is sent both as an AnswerPost and as a regular Post within the same conversation.
The Post version of the reply includes a link to navigate to the related thread, similar to Slack.

To achieve this feature, an original_post_id column has been added to the Post table. This column stores the ID of the first message in the thread (i.e., the original post), enabling seamless navigation from any reply back to its corresponding thread.

hasForwardedMessages field, which was present in both Post and AnswerPost, has been moved to the parent class Posting.

Steps for Testing

Prerequisites:

1 User
1 Course with Communication enabled

Log in to Artemis.
Navigate to the Communication section of a course.
Select a message and type a reply in the input field.
Before sending, check the "Also Send as Direct Message" checkbox below the input field.
Verify that the reply is sent both as an AnswerPost and as a regular Post in the same conversation.
Locate the "replied to a thread" line above the post.
Click the "replied to a thread" link and confirm that it navigates to the original thread.

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Code Review

Code Review 1
Code Review 2

Manual Tests

Test 1
Test 2

Test Coverage

Client

Class/File	Line Coverage	Confirmation (assert/expect)
message-reply-inline-input.component.spec.ts	not found (modified)	❌
message-reply-inline-input.component.ts	77.35%	✅ ❌
post.component.spec.ts	not found (modified)	❌
post.component.ts	93.1%	✅ ❌
posting-reactions-bar.component.ts	85.94%	✅ ❌
metis.service.spec.ts	not found (modified)	❌
metis.service.ts	90.15%	✅ ❌
course-conversations.component.ts	92.68%	✅ ❌
post.model.ts	100%	✅

Screenshots

reply input with checkbox

navigation link to the thread

Summary by CodeRabbit

New Features
- Added support for marking posts as replies with an original post reference, including UI elements to view and navigate to the original thread.
- Introduced an option to send messages as direct messages, with dynamic labels based on conversation type.
- Added new translation keys for thread-related actions and message-sending options in both English and German.
Improvements
- Enhanced post display to indicate replies and provide direct navigation to original threads.
- Improved reply and thread action buttons with context-sensitive behavior.
- Refined channel selection to exclude archived channels when forwarding posts.
- Added markdown stripping for original post content display to improve readability.
- Optimized post retrieval by ID with caching to improve performance.
- Updated navigation logic to open threads appropriately based on post type and conversation context.
Bug Fixes
- Ensured thread navigation works correctly for posts with valid conversation references.
Tests
- Added tests for toggling direct message sending, form resets, direct-message post creation, markdown stripping, and post retrieval by ID.
Style
- Introduced new CSS classes for improved layout and text handling in post components.

…ssage

…ssage # Conflicts: # src/main/webapp/app/communication/post/post.component.ts # src/test/javascript/spec/component/shared/metis/message-reply-inline-input/message-reply-inline-input.component.spec.ts

…ssage

…ssage # Conflicts: # src/main/java/de/tum/cit/aet/artemis/communication/domain/Posting.java # src/main/java/de/tum/cit/aet/artemis/communication/dto/PostingDTO.java # src/main/webapp/app/communication/message/message-reply-inline-input/message-reply-inline-input.component.spec.ts # src/main/webapp/app/communication/message/message-reply-inline-input/message-reply-inline-input.component.ts # src/main/webapp/app/communication/post/post.component.spec.ts

…ssage

PaRangger

Tested on TS4, works great! 😄

julian-wls

Thank you for implementing my review.
Everything works as expected, tested on TS4 👍

src/main/java/de/tum/cit/aet/artemis/communication/domain/Posting.java

…ssage # Conflicts: # src/main/webapp/app/communication/post/post.component.ts # src/main/webapp/app/communication/shared/entities/post.model.ts

github-actions · 2025-05-01T11:07:58Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	201 ran	194 passed	3 skipped	4 failed	53m 11s 623ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/course/CourseMessages.spec.ts
ts.Course messages › Channel messages › Write/edit/delete message in channel › Student should be able to edit message in channel	❌ failure	2m 2s 998ms
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 2s 490ms
e2e/exercise/quiz-exercise/QuizExerciseParticipation.spec.ts
ts.Quiz Exercise Participation › DnD Quiz participation › Student can participate in DnD Quiz	❌ failure	2m 3s 5ms
e2e/exercise/programming/ProgrammingExerciseStaticCodeAnalysis.spec.ts
ts.Static code analysis tests › Configures SCA grading and makes a successful submission with SCA errors	❌ failure	1m 45s 105ms

github-actions · 2025-05-01T11:57:58Z

End-to-End (E2E) Test Results Summary

	Tests	Passed ☑️	Skipped ⚠️	Failed ❌️	Time ⏱
End-to-End (E2E) Test Report	201 ran	195 passed	3 skipped	3 failed	51m 7s 665ms

Test	Result	Time ⏱
End-to-End (E2E) Test Report
e2e/course/CourseMessages.spec.ts
ts.Course messages › Channel messages › Write/edit/delete message in channel › Student should be able to edit message in channel	❌ failure	2m 3s 91ms
e2e/exercise/quiz-exercise/QuizExerciseManagement.spec.ts
ts.Quiz Exercise Management › Quiz Exercise Creation › Creates a Quiz with Drag and Drop	❌ failure	2m 2s 225ms
e2e/exercise/quiz-exercise/QuizExerciseParticipation.spec.ts
ts.Quiz Exercise Participation › DnD Quiz participation › Student can participate in DnD Quiz	❌ failure	2m 3s 901ms

eylulnc

Tested on TS1, works as described!

HawKhiem

Retested on TS1. Reapprove

FelberMartin

Re-tested on TS4

asliayk and others added 21 commits February 27, 2025 15:08

add send as direct message feature

5c531cb

minor fixes

4a5631a

fix test

559edb0

Merge branch 'develop' into feature/communication/answer-as-direct-me…

b9cae5d

…ssage

Merge branch 'develop' into feature/communication/answer-as-direct-me…

d50ff6e

…ssage

fix minor issues of forwarding message

05184b9

Merge branch 'develop' into feature/communication/answer-as-direct-me…

3f42789

…ssage # Conflicts: # src/main/webapp/app/communication/post/post.component.ts # src/test/javascript/spec/component/shared/metis/message-reply-inline-input/message-reply-inline-input.component.spec.ts

fix conflicts

67af04b

apply suggested changes

2bb194c

fix for formatted text

c7ef775

Merge branch 'develop' into feature/communication/answer-as-direct-me…

686e01c

…ssage

minor fix

d8a5658

Merge branch 'develop' into feature/communication/answer-as-direct-me…

e58e7cc

…ssage

update checkbox text

7501f31

Merge branch 'develop' into feature/communication/answer-as-direct-me…

f57511b

…ssage

update postingdto

6303d30

fix liquid

a1a54ad

import fix

e73f7af

update post field & navigation

c5d1c71

Merge branch 'develop' into feature/communication/answer-as-direct-me…

d5db7ec

…ssage

asliayk added feature tests client Pull requests that update TypeScript code. (Added Automatically!) communication Pull requests that affect the corresponding module labels Apr 24, 2025

asliayk self-assigned this Apr 24, 2025

github-project-automation bot moved this to Todo in Communication Webclient Apr 24, 2025

github-project-automation bot added this to Communication Webclient and Artemis Development Apr 24, 2025

github-project-automation bot moved this to Work In Progress in Artemis Development Apr 24, 2025

PaRangger previously approved these changes Apr 25, 2025

View reviewed changes

julian-wls previously approved these changes Apr 25, 2025

View reviewed changes

asliayk added ready to merge and removed ready for review labels Apr 25, 2025

MaximilianAnzinger requested changes Apr 26, 2025

View reviewed changes

src/main/java/de/tum/cit/aet/artemis/communication/domain/Posting.java Show resolved Hide resolved

asliayk requested a review from MaximilianAnzinger April 26, 2025 22:06

krusche removed the ready to merge label Apr 30, 2025

Merge branch 'develop' into feature/communication/answer-as-direct-me…

48b537e

…ssage # Conflicts: # src/main/webapp/app/communication/post/post.component.ts # src/main/webapp/app/communication/shared/entities/post.model.ts

asliayk dismissed stale reviews from julian-wls, PaRangger, FelberMartin, coderabbitai[bot], and HawKhiem via 48b537e May 1, 2025 10:28

coderabbitai bot previously approved these changes May 1, 2025

View reviewed changes

fix navigation

3a7638e

asliayk dismissed coderabbitai[bot]’s stale review via 3a7638e May 1, 2025 11:20

coderabbitai bot approved these changes May 1, 2025

View reviewed changes

helios-aet bot temporarily deployed to artemis-test1.artemis.cit.tum.de May 1, 2025 11:38 Inactive

asliayk requested review from julian-wls, FelberMartin, HawKhiem and PaRangger May 1, 2025 11:46

asliayk added the ready for review label May 1, 2025

eylulnc approved these changes May 1, 2025

View reviewed changes

helios-aet bot temporarily deployed to artemis-test1.artemis.cit.tum.de May 1, 2025 16:30 Inactive

HawKhiem approved these changes May 1, 2025

View reviewed changes

helios-aet bot deployed to artemis-test4.artemis.cit.tum.de May 2, 2025 10:59 View deployment

FelberMartin approved these changes May 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Communication`: Add send as regular message option for replies #10739

`Communication`: Add send as regular message option for replies #10739

asliayk commented Apr 24, 2025 •

edited by coderabbitai bot

Loading

PaRangger left a comment

julian-wls left a comment •

edited

Loading

github-actions bot commented May 1, 2025

github-actions bot commented May 1, 2025

eylulnc left a comment

HawKhiem left a comment

FelberMartin left a comment

Communication: Add send as regular message option for replies #10739

Are you sure you want to change the base?

Communication: Add send as regular message option for replies #10739

Conversation

asliayk commented Apr 24, 2025 • edited by coderabbitai bot Loading

Checklist

General

Server

Client

Motivation and Context

Description

Steps for Testing

Testserver States

Review Progress

Code Review

Manual Tests

Test Coverage

Client

Screenshots

Summary by CodeRabbit

Summary by CodeRabbit

PaRangger left a comment

Choose a reason for hiding this comment

julian-wls left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented May 1, 2025

End-to-End (E2E) Test Results Summary

github-actions bot commented May 1, 2025

End-to-End (E2E) Test Results Summary

eylulnc left a comment

Choose a reason for hiding this comment

HawKhiem left a comment

Choose a reason for hiding this comment

FelberMartin left a comment

Choose a reason for hiding this comment

`Communication`: Add send as regular message option for replies #10739

`Communication`: Add send as regular message option for replies #10739

asliayk commented Apr 24, 2025 •

edited by coderabbitai bot

Loading

julian-wls left a comment •

edited

Loading