-
Notifications
You must be signed in to change notification settings - Fork 319
Communication
: Add send as regular message option for replies
#10739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…ssage # Conflicts: # src/main/webapp/app/communication/post/post.component.ts # src/test/javascript/spec/component/shared/metis/message-reply-inline-input/message-reply-inline-input.component.spec.ts
…ssage # Conflicts: # src/main/java/de/tum/cit/aet/artemis/communication/domain/Posting.java # src/main/java/de/tum/cit/aet/artemis/communication/dto/PostingDTO.java # src/main/webapp/app/communication/message/message-reply-inline-input/message-reply-inline-input.component.spec.ts # src/main/webapp/app/communication/message/message-reply-inline-input/message-reply-inline-input.component.ts # src/main/webapp/app/communication/post/post.component.spec.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approve, tested on TS2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again on TS3. Reapprove
End-to-End (E2E) Test Results Summary
|
End-to-End (E2E) Test Results Summary |
End-to-End (E2E) Test Results Summary |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
Checklist
General
Server
Client
Motivation and Context
Currently, when replying to a message, the response is always created as an
AnswerPost
. However, there is no option to post the reply as a regularPost
instead. This limitation is not always ideal in scenarios where the reply is relevant to the entire conversation rather than just being tied to the original message. (Closes #9953)Description
This PR introduces "Also send as direct message" option when writing a reply.
AnswerPost
and as a regularPost
within the same conversation.To achieve this feature, an
original_post_id
column has been added to thePost
table. This column stores the ID of the first message in the thread (i.e., the original post), enabling seamless navigation from any reply back to its corresponding thread.hasForwardedMessages
field, which was present in bothPost
andAnswerPost
, has been moved to the parent classPosting
.Steps for Testing
Prerequisites:
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Test Coverage
Client
Screenshots
reply input with checkbox

navigation link to the thread

Summary by CodeRabbit
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Tests
Style