-
Notifications
You must be signed in to change notification settings - Fork 313
Development
: Update config for apple-site-association-file
#10760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe security configuration was modified to allow unauthenticated access to the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant SecurityFilterChain
participant Application
Client->>SecurityFilterChain: Request /.well-known/apple-app-site-association
SecurityFilterChain-->>Application: Allow request (no authentication required)
Application-->>Client: Response
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)`src/main/java/**/*.java`: naming:CamelCase; principles:{single_responsibility,small_methods,no_duplication}; db:{perf_queries,datetime_not_timestamp}; rest:{stateless,singleton,de...
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Chore
: Update config for apple-site-association-fileGeneral
: Update config for apple-site-association-file
End-to-End (E2E) Test Results Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS4/TS5 using the provided validator. TS4 without the branch failed, TS5 succeded. Code changes LGTM. ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS5. Works as described
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS5. Works as described
General
: Update config for apple-site-association-fileDevelopment
: Update config for apple-site-association-file
Checklist
General
Server
Motivation and Context
For supporting passkeys on the iOS app (and deep links from the web at some point), there needs to be an apple-app-site-association file on the server at /.well-known/apple-app-file-association which needs to be accessible without authentication.
Description
The app identifier has been updated to reflect the iOS app's actual identifier, and the security configuration has been updated to exclude this file from authentication.
Steps for Testing
Prerequisites:
A user which is NOT logged in
/.well-known/apple-app-site-association
on the serverYou can also use a validator to confirm the file structure
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Summary by CodeRabbit
/.well-known/apple-app-site-association
endpoint, making it publicly accessible.