Skip to content

Conversation

@vivienxr
Copy link

@vivienxr vivienxr commented Nov 11, 2025

Checklist

General

Server

  • I strictly followed the principle of data economy for all database calls.
  • I strictly followed the server coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I documented the Java code using JavaDoc style.

Motivation and Context

This PR fixes #11517.

Description

The method getStudentParticipationCountById() in the ExerciseRepository now only counts participants of an exercise who have the role of a student. This method is called by two methods in two services (setStudentsAndParticipationsAmountForStatisticsDTO() in ExerciseService.java and ExerciseManagementStatisticsDTO() in StatisticsService.java) which both require the number of student participants instead of the number of all participants.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 2 Students
  • 1 Exercise of any type
  1. Log in to Artemis.
  2. Let the instructor and 1 students start the exercise.
  3. Check the exercise overview in instructor view.
  4. It is supposed to show 1 out of 2.

Testserver States

No testserver tests done yet.

Review Progress

Performance Review

  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

No tests added since its only the change effectively consists of one line.

Screenshots

See screenshot of the issue.

@github-project-automation github-project-automation bot moved this to Work In Progress in Artemis Development Nov 11, 2025
@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) exercise Pull requests that affect the corresponding module labels Nov 11, 2025
@github-actions
Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report205 ran200 passed3 skipped2 failed1h 15m 5s 135ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseDropLocation.spec.ts
ts.Quiz Exercise Drop Location Spec › DnD Quiz drop locations › Checks drop locations❌ failure2m 3s 223ms
e2e/exam/test-exam/TestExamStudentExams.spec.ts
ts.Test Exam - student exams › Check exam participants and their submissions › Open the list of exam students❌ failure6m 5s 224ms

Copy link
Contributor

@florian-glombik florian-glombik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things that I noticed:

@vivienxr vivienxr changed the title Bugfix: Fix counting of participating students in exercise General: Fix counting of participating students in exercise Nov 17, 2025
@github-actions github-actions bot added the tests label Nov 17, 2025
@github-actions
Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report205 ran201 passed3 skipped1 failed1h 14m 932ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseDropLocation.spec.ts
ts.Quiz Exercise Drop Location Spec › DnD Quiz drop locations › Checks drop locations❌ failure2m 3s 729ms

@github-actions
Copy link

End-to-End (E2E) Test Results Summary

TestsPassed ☑️Skipped ⚠️Failed ❌️Time ⏱
End-to-End (E2E) Test Report205 ran200 passed3 skipped2 failed1h 14m 39s 398ms
TestResultTime ⏱
End-to-End (E2E) Test Report
e2e/exercise/quiz-exercise/QuizExerciseDropLocation.spec.ts
ts.Quiz Exercise Drop Location Spec › DnD Quiz drop locations › Checks drop locations❌ failure2m 3s 137ms
e2e/exam/test-exam/TestExamParticipation.spec.ts
ts.Test exam participation › Early Hand-in › Using exercise overview to navigate within exam❌ failure3m 42s 768ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exercise Pull requests that affect the corresponding module server Pull requests that update Java code. (Added Automatically!) tests

Projects

Status: Work In Progress

Development

Successfully merging this pull request may close these issues.

Participation rate wrongly calculated

3 participants