-
Notifications
You must be signed in to change notification settings - Fork 350
General: Fix counting of participating students in exercise
#11624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vivienxr
wants to merge
3
commits into
develop
Choose a base branch
from
bugfix/general/fix-counting-of-participating-students
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
General: Fix counting of participating students in exercise
#11624
vivienxr
wants to merge
3
commits into
develop
from
bugfix/general/fix-counting-of-participating-students
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||||||||
Contributor
florian-glombik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things that I noticed:
- The PR title does not follow the conventions yet https://docs.artemis.cit.tum.de/dev/development-process/development-process.html#naming-conventions-for-github-pull-requests
- I don't think you need the check
- [ ] **Important**: I implemented the changes with a [very good performance](https://docs.artemis.cit.tum.de/dev/guidelines/performance/) and prevented too many (unnecessary) and too complex database calls.for this PR as you directly edited the query - Can you link the respective issue with a keyword? https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword? The issue will then be closed automatically
- I think the method name could be better chosen, e.g.
countStudentParticipationsByExerciseIdorgetStudentParticipationCountByExerciseId- but not 100% sure if it interferes with JPA - Can we add a small test for it? I think you can add another test in
StatisticsIntegrationTestthat checks this value
Bugfix: Fix counting of participating students in exerciseGeneral: Fix counting of participating students in exercise
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||
End-to-End (E2E) Test Results Summary
|
||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Motivation and Context
This PR fixes #11517.
Description
The method getStudentParticipationCountById() in the ExerciseRepository now only counts participants of an exercise who have the role of a student. This method is called by two methods in two services (setStudentsAndParticipationsAmountForStatisticsDTO() in ExerciseService.java and ExerciseManagementStatisticsDTO() in StatisticsService.java) which both require the number of student participants instead of the number of all participants.
Steps for Testing
Prerequisites:
Testserver States
No testserver tests done yet.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
No tests added since its only the change effectively consists of one line.
Screenshots
See screenshot of the issue.