Development: Fix pair programming status during analysis pipeline#211
Merged
Development: Fix pair programming status during analysis pipeline#211
Development: Fix pair programming status during analysis pipeline#211Conversation
- Return null from getPairProgrammingStatus/calculateScore when no attendance data exists (instead of NOT_FOUND for every team) - Compute PP status for all teams including failed ones by moving calculateGitOnlyCqi before checkAndMarkFailed - Preserve PP fields in checkAndMarkFailed (don't clear them) - Run PP recompute synchronously after GIT_DONE to avoid race with AI analysis - Show yellow "Pending" PP badge during all analysis phases (including for failed/DONE teams when attendance is uploaded) - Fix AI_ANALYZING sort order to appear above completed teams - Fix reconstructCqiDetails to return results when only PP fields are set Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
On GIT_DONE, fetch team summaries from DB and selectively merge only pairProgrammingStatus and PP sub-metrics into the SSE-driven cache. This preserves analysisStatus (AI_ANALYZING etc.) while picking up PP statuses from the synchronous recompute. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolve conflicts in Teams.tsx: keep PP merge logic in onGitDone and adopt main's templateAuthors accumulation pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bugfix: Fix pair programming status during analysis pipelineDevelopment: Fix pair programming status during analysis pipeline
Contributor
|
🤖 No OpenAPI or client changes needed. |
1 similar comment
Contributor
|
🤖 No OpenAPI or client changes needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Client
Motivation and Context
Fixes #210
After making the server the single source of truth for PP status, all teams showed NOT_FOUND badges when no attendance was uploaded, PP badges disappeared during analysis phases, failed teams were excluded from PP analysis, and an async recompute raced with AI analysis.
Description
Server changes:
getPairProgrammingStatus()andcalculateScore()returnnullwhen no attendance data exists (no Excel uploaded), instead ofNOT_FOUNDcalculateGitOnlyCqi()beforecheckAndMarkFailed()so PP is computed for all teams including failed ones. Stop clearing PP fields when marking teams as failed. IncludecqiDetailsin the failed team response DTO.reconstructCqiDetails()now returns a result when only PP fields are set (for failed teams on page refresh)Client changes:
uploadedAttendanceFileNamedependency from PP recomputing pollSteps for Testing
Prerequisites:
Test 1: No attendance uploaded
Test 2: Attendance uploaded before analysis
Test 3: Attendance uploaded during analysis
Test 4: Page refresh
Review Progress
Code Review
Manual Tests
Screenshots
🤖 Generated with Claude Code