`General`: Fix not working everything by Predixx · Pull Request #74 · ls1intum/Harmonia

Predixx · 2025-12-18T21:57:29Z

📋 Summary

Comprehensive PR addressing code review feedback and fixing critical functionality issues across the entire stack. Improves code quality, eliminates duplication, and establishes proper architectural patterns.

Changes: 133 files changed, 9,744 insertions(+), 942 deletions(-)

🔧 Key Changes

Server

Code Quality: Added @JsonInclude annotations, moved FairnessFlag to domain package, replaced var with explicit types, fixed imports
Utilities: Created DtoUtils and CredentialUtils to eliminate duplicate code
Database: Consolidated changelogs 002-005 into 001-changelog.xml
Config: Removed unnecessary CORS ports, improved security

Client

OpenAPI Client: Migrated from manual fetch to generated TypeScript client
Error Handling: Added console.error + callback pattern for better debugging and UX
Types: Fixed TypeScript types, eliminated any usage
React Query: Replaced useEffect with useQuery for data fetching

Testing

Added 12 new test classes covering AI services, analysis, and integration tests
All critical paths have test coverage

⚠️ Breaking Changes

Database

Changelogs 002-005 removed and merged into 001-changelog.xml
For existing databases: Ensure you're on the latest migration before pulling

Frontend

Manual API fetch calls replaced with generated client from src/app/generated/

🧪 Testing

# Backend tests
./gradlew test

# Frontend
cd src/main/webapp && npm test

# Integration tests
./gradlew integrationTest

… API endpoints, and enhance UI for project selection

…configuration properties

- Add analyzeRepository method to GitContributionAnalysisService for streamlined contribution analysis. - Implement loadBasicTeamDataStream for real-time team data fetching in Teams component. - Update RequestService to clear database before saving results and improve repository processing. - Introduce StreamResource for SSE streaming of repository analysis results. - Adjust tests to accommodate new method signatures and functionality.

…: add test logging and modify repository IDs in tests

…r obsolete directories to streamline the project structure.

…sion control

….gitignore update

- Add cqi: Double field to represent collaboration quality index - Add isSuspicious: Boolean field to flag unusual team activity - Update DTO to include server-calculated team quality metrics

- Inject ContributionBalanceCalculator dependency - Calculate CQI for each team using contribution balance scores - Update ClientResponseDTO to include cqi and isSuspicious values - Pass calculated metrics to client via streaming and database APIs

- Expose new GET /api/requestResource/getData endpoint - Retrieve pre-analyzed team data from database without re-analysis - Provides fallback for loading cached team metrics

- Accept exerciseId parameter to lookup exercise-specific git repo path - Support multiple exercises with different repository configurations - Read gitRepoPath from HarmoniaProperties based on exerciseId

- Pass gitRepoPath as parameter instead of reading from config - Support exercise-specific repository storage paths - Improve flexibility for multi-exercise scenarios

- Add detailed VCS access log debugging information - Log action types and sample entries for troubleshooting - Improve error messages with participation context

- Remove exerciseId and gitRepoPath from global Artemis config - These are now exercise-specific in harmonia.projects config - Simplifies configuration management for multiple exercises

- Add cqi property for collaboration quality index - Add isSuspicious property for team anomaly detection - Regenerated from OpenAPI schema

- Add getData() method to RequestResourceApi client - Support retrieving cached team data from server - Regenerated from updated OpenAPI schema

- Add team caching to ensure consistent metrics across views - Transform ComplexTeamData using server-provided CQI values - Remove client-side CQI recalculation, use server as source-of-truth - Update stream handler to emit ComplexTeamData with full metrics - Add teamCache to prevent duplicate transformations - Update terminology: backend server in comments

- Add useQuery hook to cache teams per exercise with infinite staleTime - Prevent unnecessary re-fetching when navigating back - Check cache before initiating SSE stream - Update React Query cache in real-time as teams stream in - Invalidate cache only on explicit reanalysis request

- Pass team object via route state from Teams page - Eliminate redundant API call that fetches fresh data - Ensures CQI metrics are consistent between list and detail views - Simplify component by removing useQuery and loading states

…' with 'server'

…ide default values

…lback

…ve error handling

…y in return types

…ysisResultDTO for null value handling

…tils for consistency

…ved readability

…rtRatingDTO to use it

…edundant methods

github-actions · 2026-01-19T21:38:03Z