General: Add repository fetching from the Artemis API#8
Merged
Conversation
Cathy0123456789
changed the title
General: Add repository fetching
Contributor
|
🤖 OpenAPI spec and client code auto-updated and committed. |
Contributor
|
🤖 No OpenAPI or client changes needed. |
Contributor
|
🤖 No OpenAPI or client changes needed. |
Contributor
|
🤖 No OpenAPI or client changes needed. |
az108
requested changes
Nov 18, 2025
src/main/java/de/tum/cit/aet/repositoryProcessing/dto/ParticipantDTO.java
Show resolved
Hide resolved
Comment on lines
+26
to
+61
| public static class Builder { | ||
| private ParticipationDTO participation; | ||
| private String localPath; | ||
| private Integer commitCount; | ||
| private Boolean isCloned; | ||
| private String error; | ||
|
|
||
| public Builder participation(ParticipationDTO participation) { | ||
| this.participation = participation; | ||
| return this; | ||
| } | ||
|
|
||
| public Builder localPath(String localPath) { | ||
| this.localPath = localPath; | ||
| return this; | ||
| } | ||
|
|
||
| public Builder commitCount(Integer commitCount) { | ||
| this.commitCount = commitCount; | ||
| return this; | ||
| } | ||
|
|
||
| public Builder isCloned(Boolean isCloned) { | ||
| this.isCloned = isCloned; | ||
| return this; | ||
| } | ||
|
|
||
| return new TeamRepositoryDTO( | ||
| teamRepository.getTeamRepositoryId() | ||
| ); | ||
| public Builder error(String error) { | ||
| this.error = error; | ||
| return this; | ||
| } | ||
|
|
||
| public TeamRepositoryDTO build() { | ||
| return new TeamRepositoryDTO(participation, localPath, commitCount, isCloned, error); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
having a static class is not good inside a dto. if we want to keep this then please make an util class instead which uses the TeamRepositoryDTO.
src/main/java/de/tum/cit/aet/repositoryProcessing/service/ArtemisClientService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/cit/aet/repositoryProcessing/service/GitOperationsService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/cit/aet/repositoryProcessing/service/GitOperationsService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/tum/cit/aet/repositoryProcessing/service/RepositoryFetchingService.java
Outdated
Show resolved
Hide resolved
Contributor
|
🤖 No OpenAPI or client changes needed. |
Contributor
|
🤖 No OpenAPI or client changes needed. |
Contributor
|
🤖 No OpenAPI or client changes needed. |
az108
approved these changes
Nov 18, 2025
Collaborator
|
Thanks for implementing the changes, clean code you wrote 💯 |
az108
changed the title
General: Add repository fetchingGeneral: Add repository fetching from the Artemis API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Motivation and Context
Description
Review Progress
Code Review