Skip to content

chore: Seperate test processor logic into its own service #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: staging
Choose a base branch
from

Conversation

StefanNemeth
Copy link
Contributor

@StefanNemeth StefanNemeth commented Mar 11, 2025

Motivation

Right now the test processor is part of the application server code. However, with increasing complexity of the processor that could lead to some maintainability issues in the future.

Description

This PR seperates the downloading of test artifacts, extraction of zip files and parsing of test files into its own microservice called test-processor. I'm making use of our existing NATS service for communication. Additionally, the test processor provides the actual results with a REST API as the data is too large for sending it via nats.

Testing Instructions

Displaying test results: Try to generate some test results (see test instructions of #341) on your branch/PR. You'll need to run the test processor as well (run ./gradlew :test-processor:bootRunDev within server directory). Also make sure that your .env file is moved to the server directory.

Checklist

General

Copy link

codacy-production bot commented Mar 11, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.54% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4d9adfa) 5699 874 15.34%
Head commit (61b5013) 5505 (-194) 874 (+0) 15.88% (+0.54%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#524) 3 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@StefanNemeth StefanNemeth force-pushed the chore/microservice-test-processor branch from 0354676 to 4d9adfa Compare March 18, 2025 09:56
Copy link

github-actions bot commented Mar 18, 2025

🚨 OpenAPI Validation Failed 🚨

The OpenAPI specs in openapi.yaml differ from the generated version.
Please update the OpenAPI specs by running:

cd ./server
./gradlew :application-server:generateOpenApiDocs

Commit and push the updated file.

@github-actions github-actions bot added size:XXL and removed size:XL labels Mar 18, 2025
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 27, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation github-config labels Mar 29, 2025
@StefanNemeth StefanNemeth marked this pull request as ready for review March 29, 2025 23:12
Copy link

github-actions bot commented Apr 6, 2025

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@StefanNemeth StefanNemeth marked this pull request as draft April 14, 2025 11:19
@StefanNemeth
Copy link
Contributor Author

StefanNemeth commented Apr 14, 2025

I'll put it back into "Ready for review" once the conflicts are resolved.

Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant