Skip to content

feat(proxy): Disable health checks for production initially#53

Open
krusche wants to merge 1 commit intomainfrom
feature/proxy-health-check
Open

feat(proxy): Disable health checks for production initially#53
krusche wants to merge 1 commit intomainfrom
feature/proxy-health-check

Conversation

@krusche
Copy link
Copy Markdown
Member

@krusche krusche commented Feb 2, 2026

Summary

Disable active health checks for the production environment initially, following a staged rollout strategy. Staging environments will use the default (enabled) configuration from the ansible collection.

Staged Rollout Strategy

  1. Staging environments (artemis-staging1, artemis-staging2, artemis-staging-localci): Health checks enabled by default from collection
  2. Production: Health checks disabled initially via this PR
  3. After verification: Remove proxy_health_check_enabled: false from this file to enable in production

Related PRs

Repository PR Description
Artemis ls1intum/Artemis#12078 Add /ping endpoint via Tomcat Valve
artemis-ansible-collection ls1intum/artemis-ansible-collection#182 Add health check script/templates to proxy role

Changes

  • Add proxy_health_check_enabled: false to group_vars/artemis_production.yml

Verification Steps

After merging the collection PR and deploying to staging:

# On staging proxy server
systemctl status nginx-health-check.timer
journalctl -t nginx-health-check -f

# Test by freezing a node
ssh staging-node1 "kill -STOP \$(pgrep -f artemis)"
watch -n1 cat /etc/nginx/artemis-http-upstream.conf
# Should show "down" for frozen server within ~3s

Once verified on staging, remove the proxy_health_check_enabled: false line from this file to enable health checks in production.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Added proxy health check configuration option to production environment (initially disabled pending verification)

Disable active health checks for production environment until the feature
is verified on staging environments. Staging environments will use the
default (enabled) from artemis-ansible-collection.

After successful testing on staging, remove this line to enable health
checks in production.

Related PRs:
- Artemis: ls1intum/Artemis#12078
- Collection: ls1intum/artemis-ansible-collection#182

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@krusche krusche requested a review from a team as a code owner February 2, 2026 19:36
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

A new configuration flag for proxy health checks was added to the Artemis production configuration file, initially set to disabled with a comment noting it should be enabled after staging verification.

Changes

Cohort / File(s) Summary
Proxy Configuration
group_vars/artemis_production.yml
Added proxy_health_check_enabled flag set to false with a note to enable after staging verification.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A checkbox appears in config land,
Health checks paused, as briefly planned,
Staging waits for verification's call,
Then springs to life and checks them all!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: disabling proxy health checks in production initially, which is the primary purpose of adding the proxy_health_check_enabled flag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/proxy-health-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant