feat(proxy): Disable health checks for production initially#53
Open
feat(proxy): Disable health checks for production initially#53
Conversation
Disable active health checks for production environment until the feature is verified on staging environments. Staging environments will use the default (enabled) from artemis-ansible-collection. After successful testing on staging, remove this line to enable health checks in production. Related PRs: - Artemis: ls1intum/Artemis#12078 - Collection: ls1intum/artemis-ansible-collection#182 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughA new configuration flag for proxy health checks was added to the Artemis production configuration file, initially set to disabled with a comment noting it should be enabled after staging verification. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable active health checks for the production environment initially, following a staged rollout strategy. Staging environments will use the default (enabled) configuration from the ansible collection.
Staged Rollout Strategy
proxy_health_check_enabled: falsefrom this file to enable in productionRelated PRs
/pingendpoint via Tomcat ValveChanges
proxy_health_check_enabled: falsetogroup_vars/artemis_production.ymlVerification Steps
After merging the collection PR and deploying to staging:
Once verified on staging, remove the
proxy_health_check_enabled: falseline from this file to enable health checks in production.🤖 Generated with Claude Code
Summary by CodeRabbit