-
Notifications
You must be signed in to change notification settings - Fork 3
Iris
: Merge ingestion jobs
#85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Iris
: Merge ingestion jobs
#85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks all in all good to me, some small suggestions I would like you to change.
node_modules/.cache/prettier/.prettier-caches/4f86833ecaf1b3781892bfdfd08553ccb5ebf45d.json
Outdated
Show resolved
Hide resolved
I integrated you feedback, can you have a look again @alexjoham :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small point but all in all it looks good! Will approve if this is fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me! Approved!
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
The ingestion jobs for lecture slides and transcriptions are now merged.
/lectures/fullIngestion
pathTo test:
With the id of you AttachemntVideoUnit and the id of the corresponding lecture
Example transcription:
Screenshots: