Skip to content

Iris: Merge ingestion jobs #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

isabellagessl
Copy link
Contributor

@isabellagessl isabellagessl commented Apr 1, 2025

The ingestion jobs for lecture slides and transcriptions are now merged.

  • slides and transcriptions can be ingested over the /lectures/fullIngestion path
  • If an attachment was already ingested it won't be ingested again
  • Lecture unit segment summaries and leture unit summaries are generated for both slides and transcriptions after they were ingested.

To test:

  1. Create an AttachmentVideoUnit in Artemis
  2. Upload a file (slidedeck) and set a videoSource
  3. Upload transcriptions for the Unit under /admin/lecture-transcription-ingestion
    With the id of you AttachemntVideoUnit and the id of the corresponding lecture
    Example transcription:
 {
    "lectureUnitId": 1,
    "language": "en",
    "segments": [
        {
            "startTime": 0.96,
            "endTime": 5.36,
            "text": "Welcome to the second lecture in the course Introduction to Software Engineering.",
            "slideNumber": 1
        },
        {
            "startTime": 5.36,
            "endTime": 11.120000000000001,
            "text": "Today we would like to talk about model-based software engineering from the problem statement",
            "slideNumber": 2
        },
        {
            "startTime": 11.120000000000001,
            "endTime": 17.04,
            "text": "to the potentially shippable product increment that you deliver to your end users.",
            "slideNumber": 3
        }
    ]
}
  1. In the management of the course in Artemis ingest the lecture unti
  2. See if the ingestion works in the Pyris console output

Screenshots:

  1. step
Bildschirmfoto 2025-04-05 um 16 30 50
  1. step
Bildschirmfoto 2025-04-05 um 16 56 13
  1. step
Bildschirmfoto 2025-04-05 um 16 36 53
  1. step
Bildschirmfoto 2025-04-05 um 16 37 31

Copy link
Member

@alexjoham alexjoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks all in all good to me, some small suggestions I would like you to change.

@isabellagessl isabellagessl requested a review from a team as a code owner April 5, 2025 07:44
@isabellagessl isabellagessl requested a review from alexjoham April 5, 2025 07:47
@isabellagessl
Copy link
Contributor Author

I integrated you feedback, can you have a look again @alexjoham :)

Copy link
Member

@alexjoham alexjoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small point but all in all it looks good! Will approve if this is fixed!

Copy link
Member

@alexjoham alexjoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! Approved!

Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants