Add a disclaimer in the application window for students#854
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds a topical disclaimer text constant and surfaces it as an informational, light-blue Alert with an InfoIcon in two pages (SelectTopicStep and LandingPage). Also adjusts LandingPageHeader spacing and LogoCircle sizes. No data-fetching, interaction behavior, or exported API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
client/src/pages/ReplaceApplicationPage/components/SelectTopicStep/SelectTopicStep.tsx (1)
68-71: Consider adding atitleprop for better screen reader labelling.Mantine Alert sets
aria-labelledbyto the title element id only if a title is provided. Withouttitle, screen readers have no label associated with therole="alert"root — the body text is still announced, but a short title (e.g."Eligibility Notice") improves clarity for assistive technology.♻️ Suggested improvement
- <Alert variant='light' color='blue' icon={<InfoIcon />} mb='md'> + <Alert variant='light' color='blue' icon={<InfoIcon />} mb='md' title='Eligibility Notice'>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@client/src/pages/ReplaceApplicationPage/components/SelectTopicStep/SelectTopicStep.tsx` around lines 68 - 71, The Alert in SelectTopicStep (the Alert component usage inside SelectTopicStep.tsx) lacks a title prop which prevents Mantine from setting aria-labelledby; add a concise title prop (e.g. "Eligibility Notice" or similar) to the Alert invocation so a title element/id is rendered and screen readers get a proper label, leaving the existing body text unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@client/src/pages/ReplaceApplicationPage/components/SelectTopicStep/SelectTopicStep.tsx`:
- Around line 68-71: The Alert in SelectTopicStep (the Alert component usage
inside SelectTopicStep.tsx) lacks a title prop which prevents Mantine from
setting aria-labelledby; add a concise title prop (e.g. "Eligibility Notice" or
similar) to the Alert invocation so a title element/id is rendered and screen
readers get a proper label, leaving the existing body text unchanged.
Summary
Add an informational disclaimer on the first step of the application process ("Select Topic") to remind students that topics are offered by different research groups and that they need to verify their eligibility before applying
Test plan
Closes #785
Summary by CodeRabbit
New Features
Style