Skip to content

Add a disclaimer in the application window for students#854

Merged
krusche merged 2 commits intodevelopfrom
feature/application-disclaimer
Feb 25, 2026
Merged

Add a disclaimer in the application window for students#854
krusche merged 2 commits intodevelopfrom
feature/application-disclaimer

Conversation

@krusche
Copy link
Copy Markdown
Member

@krusche krusche commented Feb 22, 2026

Summary

Add an informational disclaimer on the first step of the application process ("Select Topic") to remind students that topics are offered by different research groups and that they need to verify their eligibility before applying

Test plan

  • Navigate to the "Submit Application" page
  • Verify a blue info alert is displayed above the topic search filters
  • Confirm the alert text is clear and readable

Closes #785

Summary by CodeRabbit

  • New Features

    • Added an informational alert (info icon, light blue style) above topic search on the landing and topic-selection pages to remind users to verify eligibility with the offering research group before applying.
    • Introduced a reusable disclaimer text used by these alerts.
  • Style

    • Reduced header card padding and slightly smaller logo sizes in the landing header.

@krusche krusche self-assigned this Feb 22, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4463d13 and bb8b8f3.

📒 Files selected for processing (4)
  • client/src/components/TopicDisclaimerAlert/TopicDisclaimerAlert.tsx
  • client/src/pages/LandingPage/LandingPage.tsx
  • client/src/pages/LandingPage/components/LandingPageHeader/LandingPageHeader.tsx
  • client/src/pages/ReplaceApplicationPage/components/SelectTopicStep/SelectTopicStep.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • client/src/pages/ReplaceApplicationPage/components/SelectTopicStep/SelectTopicStep.tsx

Walkthrough

Adds a topical disclaimer text constant and surfaces it as an informational, light-blue Alert with an InfoIcon in two pages (SelectTopicStep and LandingPage). Also adjusts LandingPageHeader spacing and LogoCircle sizes. No data-fetching, interaction behavior, or exported API changes.

Changes

Cohort / File(s) Summary
Disclaimer text & alert usage
client/src/components/TopicDisclaimerAlert/TopicDisclaimerAlert.tsx, client/src/pages/ReplaceApplicationPage/components/SelectTopicStep/SelectTopicStep.tsx, client/src/pages/LandingPage/LandingPage.tsx
Adds exported TOPIC_DISCLAIMER_TEXT constant and inserts an informational Alert (InfoIcon, light blue variant) above TopicSearchFilters on both SelectTopicStep and LandingPage. UI-only change; no data or interaction logic modified.
Header layout tweak
client/src/pages/LandingPage/components/LandingPageHeader/LandingPageHeader.tsx
Adjusts Card padding from p='xl' to p='md' and reduces LogoCircle size from 100/80 -> 80/60. Layout-only cosmetic change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning Padding and logo size adjustments in LandingPageHeader appear unrelated to the disclaimer feature objectives and should be justified or separated. Either remove the LandingPageHeader styling changes or justify them in the PR description as part of a broader UI polish initiative.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: adding a disclaimer alert for students in the application process, specifically on the SelectTopicStep page.
Linked Issues check ✅ Passed The PR fulfills the core requirements of issue #785: displaying a disclaimer informing students that topics are from different research groups and reminding them to verify eligibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/application-disclaimer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
client/src/pages/ReplaceApplicationPage/components/SelectTopicStep/SelectTopicStep.tsx (1)

68-71: Consider adding a title prop for better screen reader labelling.

Mantine Alert sets aria-labelledby to the title element id only if a title is provided. Without title, screen readers have no label associated with the role="alert" root — the body text is still announced, but a short title (e.g. "Eligibility Notice") improves clarity for assistive technology.

♻️ Suggested improvement
-      <Alert variant='light' color='blue' icon={<InfoIcon />} mb='md'>
+      <Alert variant='light' color='blue' icon={<InfoIcon />} mb='md' title='Eligibility Notice'>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@client/src/pages/ReplaceApplicationPage/components/SelectTopicStep/SelectTopicStep.tsx`
around lines 68 - 71, The Alert in SelectTopicStep (the Alert component usage
inside SelectTopicStep.tsx) lacks a title prop which prevents Mantine from
setting aria-labelledby; add a concise title prop (e.g. "Eligibility Notice" or
similar) to the Alert invocation so a title element/id is rendered and screen
readers get a proper label, leaving the existing body text unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@client/src/pages/ReplaceApplicationPage/components/SelectTopicStep/SelectTopicStep.tsx`:
- Around line 68-71: The Alert in SelectTopicStep (the Alert component usage
inside SelectTopicStep.tsx) lacks a title prop which prevents Mantine from
setting aria-labelledby; add a concise title prop (e.g. "Eligibility Notice" or
similar) to the Alert invocation so a title element/id is rendered and screen
readers get a proper label, leaving the existing body text unchanged.

@krusche krusche merged commit 86d4f57 into develop Feb 25, 2026
11 of 12 checks passed
@krusche krusche deleted the feature/application-disclaimer branch February 25, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disclaimer for Application

1 participant