`Development`: Cron job for user data deletion after inactivity #1704

sachmii · 2026-01-15T16:37:04Z

Checklist

General

I tested all changes and their related features with all corresponding user types.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the principle of data economy for all database calls.
I strictly followed the server coding and design guidelines.
I documented the Java code using JavaDoc style.

Motivation and Context

User data needs to be deleted after 'x' years of inactivity. The variable x can be set by setting the application property USER_RETENTION_INACTIVE_DAYS_BEFORE_DELETION.

Description

Steps for Testing

Prerequisites:

Use #1738 test PR to test and check this PR.

Review Progress

Code Review

Code Review 1

Manual Tests

Test 1

Test Coverage

Warning: Server tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-01-22 18:14:21 UTC

…/github.com/ls1intum/tum-apply into feat/1696-delete-user-data-after-inactivity

…r retention service/job with endpoint to get inactive users

…thods to delete

github-actions · 2026-01-15T16:40:12Z

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

github-actions · 2026-01-15T16:43:21Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-01-19T21:09:48Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-01-20T07:32:35Z

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-20T07:33:52Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-01-20T07:51:52Z

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

Kiara65

Left some comments on the code, rest of the code lgtm, thank you 😄

src/main/java/de/tum/cit/aet/core/config/UserRetentionProperties.java

src/main/java/de/tum/cit/aet/core/retention/UserRetentionJob.java

src/main/java/de/tum/cit/aet/core/retention/UserRetentionService.java

Abi107717

Code LGTM

github-actions · 2026-01-22T17:50:52Z

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

…t/delete-user-data-after-inactivity

github-actions · 2026-01-22T17:52:46Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-01-22T17:58:37Z

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-22T18:00:02Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-01-22T18:14:22Z

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

github-actions · 2026-01-22T18:15:42Z

🤖 No OpenAPI or client changes needed.

sachmii and others added 8 commits January 14, 2026 18:13

implement last activity at

4317af3

add missing comment

eccea16

Merge branch 'main' into feat/1696-delete-user-data-after-inactivity

3b0c16d

chore: update OpenAPI spec and generated client

bb36eec

use localdatetime instead of instant

20acce7

Merge branch 'feat/1696-delete-user-data-after-inactivity' of https:/…

ba0a9de

…/github.com/ls1intum/tum-apply into feat/1696-delete-user-data-after-inactivity

feat: 1. user retention properties in yaml file and java class 2. use…

fb0e379

…r retention service/job with endpoint to get inactive users

feat: implemented applicant data deletion and necessary repository me…

0693cb3

…thods to delete

sachmii self-assigned this Jan 15, 2026

sachmii linked an issue Jan 15, 2026 that may be closed by this pull request

Delete user data after x years of inactivity #1696

Open

sachmii added 2 commits January 19, 2026 20:09

merge

2310815

user retention i guess implemented so far

2238585

github-actions bot added job Code changes in job module. and removed client Pull requests that update TypeScript code. (Added Automatically!) labels Jan 19, 2026

sachmii added 7 commits January 19, 2026 22:57

logic should be working

0044042

pls work

5b66be2

just oncew insert

cfa1b4c

fix

b49e111

fix codacy

d3f0860

fix

f4d43c7

nerv nicht

8a9800c

update docs

9151309

sachmii removed a link to an issue Jan 20, 2026

Delete user data after x years of inactivity #1696

Open

sachmii linked an issue Jan 20, 2026 that may be closed by this pull request

Cron job for user data deletion after inactivity #1736

Open

sachmii changed the title ~~Development: Delete user data after inactivity~~ Development: Cron job for user data deletion after inactivity Jan 20, 2026

sachmii mentioned this pull request Jan 20, 2026

Development: Tests for deleting user data after inactivity #1738

Open

7 tasks

sachmii added the ready for review label Jan 20, 2026

sachmii marked this pull request as ready for review January 20, 2026 07:50

sachmii requested a review from az108 as a code owner January 20, 2026 07:50

sachmii requested review from Abi107717, Bofan-Zhu, Cathy0123456789, CelineLahnor, Kiara65 and ge94zec January 20, 2026 10:44

Kiara65 requested changes Jan 21, 2026

View reviewed changes

src/main/java/de/tum/cit/aet/core/config/UserRetentionProperties.java Show resolved Hide resolved

src/main/java/de/tum/cit/aet/core/retention/UserRetentionJob.java Show resolved Hide resolved

src/main/java/de/tum/cit/aet/core/retention/UserRetentionService.java Outdated Show resolved Hide resolved

Abi107717 approved these changes Jan 22, 2026

View reviewed changes

fix data getter

e7bdcbc

Merge branch 'main' of https://github.com/ls1intum/tum-apply into fea…

0222b01

…t/delete-user-data-after-inactivity

fix batch delete

956a5cd

sachmii requested a review from Kiara65 January 22, 2026 17:57

fix batch delete

ea3b8a9

Development: Cron job for user data deletion after inactivity #1704

Are you sure you want to change the base?

Development: Cron job for user data deletion after inactivity #1704

Uh oh!

Conversation

sachmii commented Jan 15, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Server

Motivation and Context

Description

Steps for Testing

Review Progress

Code Review

Manual Tests

Test Coverage

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

Kiara65 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Abi107717 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

github-actions bot commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

`Development`: Cron job for user data deletion after inactivity #1704

`Development`: Cron job for user data deletion after inactivity #1704

sachmii commented Jan 15, 2026 •

edited by github-actions bot

Loading