General: Fix school names filter for CIT
#1739
Conversation
github-actions
bot
added
server
|
@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details. |
|
📊 Server Test Coverage Too Low 🔍 View coverage locally: ./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html🌐 View coverage from GitHub: |
|
@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details. |
|
🤖 OpenAPI spec and client code auto-updated and committed. |
|
@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details. |
|
🤖 No OpenAPI or client changes needed. |
CelineLahnor
left a comment
CelineLahnor
left a comment
There was a problem hiding this comment.
LGTM! Tested it on the test server and it looks fine for me. Thank you :)
|
🤖 No OpenAPI or client changes needed. |
|
@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details. |
Kiara65
left a comment
Kiara65
left a comment
There was a problem hiding this comment.
Works as expected, thank you 🥳
| String[] schoolNames = request.getParameterValues("schoolNames"); | ||
| if (schoolNames != null) { | ||
| filterDTO.setSchoolNames(Arrays.asList(schoolNames)); | ||
| } |
There was a problem hiding this comment.
why is this in the resource level
Checklist
General
Server
Motivation and Context
Closes #1640.
Previously, when filtering for CIT in the departments view, the results wouldn't appear only after selecting another school.
Description
DepartmentResourceSteps for Testing
Prerequisites:
Review Progress
Code Review
Manual Tests
Test Coverage
Warning: Server tests failed. Coverage could not be fully measured. Please check the workflow logs.
Last updated: 2026-01-21 14:27:11 UTC
Screenshots