Skip to content

Conversation

@sachmii
Copy link
Contributor

@sachmii sachmii commented Jan 20, 2026

Checklist

General

Client

  • I strictly followed the client coding and design guidelines.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Closes #1740.

Description

  • Consolidated Research Group admin actions into an Actions menu; View remains a separate button
  • Approve/Deny/Withdraw now open confirm dialogs from the Actions menu
    Added menu wiring with guards for missing researchGroup.id

Steps for Testing

Prerequisites:

  1. Log in to TumApply Admin
  2. Check departments and research group view
  3. Check create-buttons and different icons

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Test Coverage

Warning: Client tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-01-21 14:14:03 UTC

Screenshots

image
Screenshot 2026-01-20 at 19 40 47

@sachmii sachmii self-assigned this Jan 20, 2026
@sachmii sachmii requested a review from az108 as a code owner January 20, 2026 09:53
@sachmii sachmii linked an issue Jan 20, 2026 that may be closed by this pull request
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 20, 2026
@github-actions
Copy link
Contributor

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@sachmii sachmii requested a review from Bofan-Zhu January 20, 2026 10:44
@github-actions
Copy link
Contributor

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@sachmii sachmii changed the title General: Rework admin views icons and buttons General: Rework admin views icons Jan 20, 2026
@github-actions
Copy link
Contributor

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@sachmii sachmii changed the title General: Rework admin views icons General: Rework admin views icons and detail view Jan 20, 2026
@github-actions
Copy link
Contributor

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

Copy link
Contributor

@CelineLahnor CelineLahnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That you for implementing this. I tested it on the test server and the Research Group Detail View is not looking as expected. Please have a look on that
image

@Bofan-Zhu
Copy link
Contributor

That you for implementing this. I tested it on the test server and the Research Group Detail View is not looking as expected. Please have a look on that image

I think you forgot to pull for me it looks like this
image

@Bofan-Zhu
Copy link
Contributor

Small thing I noticed, the manage members page is empty (looks broken) if there are no members, should we adjust this? Just add a text that there are no members? (Can be done in another PR)
image
Rest lgtm

@CelineLahnor
Copy link
Contributor

That you for implementing this. I tested it on the test server and the Research Group Detail View is not looking as expected. Please have a look on that image

I think you forgot to pull for me it looks like this image

Yeah I realized I was at the wrong PR branch. I checked it again and its working fine

@sachmii sachmii added ready for merge PR is ready to merge and removed ready for review labels Jan 21, 2026
@sachmii
Copy link
Contributor Author

sachmii commented Jan 21, 2026

Small thing I noticed, the manage members page is empty (looks broken) if there are no members, should we adjust this? Just add a text that there are no members? (Can be done in another PR) image Rest lgtm

Will do this in a follow up, thx for testing

@github-actions
Copy link
Contributor

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

Copy link
Contributor

@Kiara65 Kiara65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 😄

Copy link
Contributor

@Abi107717 Abi107717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally LGTM, thank you

@az108 az108 merged commit ae0ac7f into main Jan 22, 2026
22 of 23 checks passed
@az108 az108 deleted the chore/1740-summarise-icons-and-move-buttons-in-admin-views branch January 22, 2026 22:37
@az108 az108 changed the title General: Rework admin views icons and detail view Development: Rework admin views icons and detail view Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests that update TypeScript code. (Added Automatically!) ready for merge PR is ready to merge tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Summarise icons and move buttons in admin table

7 participants