Skip to content

Conversation

@Bofan-Zhu
Copy link
Contributor

@Bofan-Zhu Bofan-Zhu commented Jan 20, 2026

Checklist

General

Motivation and Context

Some buttons are misaligned and do not seem like they belong to their content.

Description

This PR aligns all buttons on the professor page to their content (top right of the content)

Steps for Testing

Prerequisites:

  1. Log in to TumApply as Professor
  2. Check alignment of buttons

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Screenshots

image image image

@Bofan-Zhu Bofan-Zhu self-assigned this Jan 20, 2026
@Bofan-Zhu Bofan-Zhu linked an issue Jan 20, 2026 that may be closed by this pull request
1 task
@Bofan-Zhu Bofan-Zhu marked this pull request as ready for review January 20, 2026 15:02
@Bofan-Zhu Bofan-Zhu requested a review from az108 as a code owner January 20, 2026 15:02
@github-actions github-actions bot added client Pull requests that update TypeScript code. (Added Automatically!) ready for review labels Jan 20, 2026
@github-actions
Copy link
Contributor

📊 Client Test Coverage Too Low

🔍 View coverage locally:

npm run test:ci
open build/test-results/lcov-report/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

Copy link
Contributor

@CelineLahnor CelineLahnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested it on the test server and also had a look on the Code. One thing I noticed is that the second filter selector is longer than the first one and maybe if we make the second one in the same length as the first one we get even a better alignment
image

@Bofan-Zhu
Copy link
Contributor Author

LGTM! I tested it on the test server and also had a look on the Code. One thing I noticed is that the second filter selector is longer than the first one and maybe if we make the second one in the same length as the first one we get even a better alignment image

Thanks for reviewing. I would change that in another PR. I think one is wider than the other because the sort displays the current sorted state but the multi select does not display the currently selected options and they both have different width (different components)

@Bofan-Zhu Bofan-Zhu added ready for merge PR is ready to merge and removed ready for review labels Jan 21, 2026
Copy link
Contributor

@Cathy0123456789 Cathy0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS, looks good, thank you!

Copy link
Contributor

@Kiara65 Kiara65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@Abi107717 Abi107717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@az108 az108 merged commit f6dea9f into main Jan 22, 2026
27 checks passed
@az108 az108 deleted the 1753-move-action-buttons-to-the-top branch January 22, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client Pull requests that update TypeScript code. (Added Automatically!) ready for merge PR is ready to merge tests ui/ux improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move action buttons to the top

7 participants