Skip to content

General: Remove first banner line #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
az108 merged 2 commits into from
Jan 22, 2026
Merged

General: Remove first banner line #1757

az108 merged 2 commits into from
Jan 22, 2026

Conversation

@Bofan-Zhu
Copy link
Contributor

@Bofan-Zhu Bofan-Zhu commented Jan 20, 2026 •
edited
Loading

Checklist

General

Motivation and Context

The banner currently has some duplicated text.

Description

This PR:

  • removes the first banner line
  • removes banner for authenticated users

Steps for Testing

Prerequisites:

  1. Navigate to landing page/professor landing page & check banner (unauthenticated)
  2. Login as Professor/Applicant/Admin
  3. Check that banner is not displayed

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Screenshots

image image

@Bofan-Zhu Bofan-Zhu self-assigned this Jan 20, 2026
@Bofan-Zhu Bofan-Zhu requested a review from az108 as a code owner January 20, 2026 15:25
@Bofan-Zhu Bofan-Zhu linked an issue Jan 20, 2026 that may be closed by this pull request
Revert banner line #1756
Closed
1 task
@Bofan-Zhu Bofan-Zhu added ready for review ui/ux improvement shared Code changes in shared modules labels Jan 20, 2026
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 20, 2026
Abi107717
Abi107717 approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@Abi107717 Abi107717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Kiara65
Kiara65 approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@Kiara65 Kiara65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Bofan-Zhu Bofan-Zhu added ready for merge PR is ready to merge and removed ready for review labels Jan 21, 2026
Cathy0123456789
Cathy0123456789 reviewed Jan 21, 2026
View reviewed changes
Copy link
Contributor

@Cathy0123456789 Cathy0123456789 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@az108 az108 merged commit ba60a4d into main Jan 22, 2026
30 checks passed
@az108 az108 deleted the 1756-revert-banner-line branch January 22, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cathy0123456789 Cathy0123456789 Cathy0123456789 approved these changes

@az108 az108 az108 approved these changes

@sachmii sachmii sachmii approved these changes

@Abi107717 Abi107717 Abi107717 approved these changes

@Kiara65 Kiara65 Kiara65 approved these changes

Assignees

@Bofan-Zhu Bofan-Zhu

Labels

client Pull requests that update TypeScript code. (Added Automatically!) ready for merge PR is ready to merge shared Code changes in shared modules ui/ux improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revert banner line

7 participants

@Bofan-Zhu @Cathy0123456789 @az108 @sachmii @Abi107717 @Kiara65