Skip to content

General: Add margin bottom to select component label #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
az108 merged 1 commit into from
Jan 22, 2026
Merged

General: Add margin bottom to select component label #1761

az108 merged 1 commit into from
Jan 22, 2026
+1 −0

Conversation

@Bofan-Zhu
Copy link
Contributor

@Bofan-Zhu Bofan-Zhu commented Jan 20, 2026 •
edited by Abi107717
Loading

Checklist

General

Motivation and Context

The select component labels currently do not have a margin bottom like other form input fields

Description

Add margin-bottom to select component labels

Steps for Testing

Prerequisites:

  1. Log in to TumApply as Applicant
  2. Apply to a Job and check all form fields

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Screenshots

image

@Bofan-Zhu Bofan-Zhu self-assigned this Jan 20, 2026
@Bofan-Zhu Bofan-Zhu requested a review from az108 as a code owner January 20, 2026 15:54
@Bofan-Zhu Bofan-Zhu linked an issue Jan 20, 2026 that may be closed by this pull request
Fix padding for select component label #1760
Closed
1 task
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Jan 20, 2026
Kiara65
Kiara65 approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@Kiara65 Kiara65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix 😊

Abi107717
Abi107717 approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@Abi107717 Abi107717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this :)
LGTM

@Bofan-Zhu Bofan-Zhu added ready for merge PR is ready to merge and removed ready for review labels Jan 20, 2026
Cathy0123456789
Cathy0123456789 approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@Cathy0123456789 Cathy0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS, looks good

@az108 az108 merged commit e34ad33 into main Jan 22, 2026
27 of 28 checks passed
@az108 az108 deleted the 1760-fix-padding-for-select-component-label branch January 22, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cathy0123456789 Cathy0123456789 Cathy0123456789 approved these changes

@az108 az108 az108 approved these changes

@sachmii sachmii sachmii approved these changes

@Abi107717 Abi107717 Abi107717 approved these changes

@Kiara65 Kiara65 Kiara65 approved these changes

Assignees

@Bofan-Zhu Bofan-Zhu

Labels

client Pull requests that update TypeScript code. (Added Automatically!) ready for merge PR is ready to merge ui/ux improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix padding for select component label

7 participants

@Bofan-Zhu @Cathy0123456789 @az108 @sachmii @Abi107717 @Kiara65