DM-49004 : Implement Panda WMS#163
Merged
tcjennings merged 4 commits intotickets/DM-49324/releasefrom Mar 21, 2025
Merged
Conversation
tcjennings
force-pushed
the
tickets/DM-49004/panda
branch
8 times, most recently
from
ec77849 to
4cf4d11
Compare
Automatically generated by python-semantic-release
tcjennings
force-pushed
the
tickets/DM-49004/panda
branch
3 times, most recently
from
8f5d05a to
51b2cf7
Compare
ctslater
approved these changes
Mar 21, 2025
Member
ctslater
left a comment
ctslater
left a comment
There was a problem hiding this comment.
Looks great, nothing particularly substantive to add.
| {%- elif wms == "panda" %} | ||
| {# what value is this LATEST_PANDA path? #} | ||
| {# LATEST_PANDA=$(ls -td /cvmfs/sw.lsst.eu/almalinux-x86_64/panda_env/v* | head -1) #} | ||
| export PANDA_SYS=${CONDA_PREFIX} |
Member
There was a problem hiding this comment.
My read is that PANDA_SYS is a different conda env than the stack conda env, so is this going to point to the right place?
Collaborator
Author
There was a problem hiding this comment.
That identity is straight from the canonical setup_panda.sh script ( /cvmfs/sw.lsst.eu/linux-x86_64/panda_env/v1.0.17/setup_panda.sh), so it ought to!
src/lsst/cmservice/common/panda.py
Outdated
| ) | ||
|
|
||
| _ = refresh_panda_token(token_endpoint, data) | ||
| except httpx.HTTPStatusError: |
Member
There was a problem hiding this comment.
I could imagine wanting to catch json parsing errors or missing keys in the Panda responses somewhere too, maybe here?
Default expiry to None. Decode expiry from token only when needed. Make panda token checking a noop if panda is unconfigured. Check panda token before building bps submit environment.
tcjennings
force-pushed
the
tickets/DM-49004/panda
branch
from
51b2cf7 to
1c00469
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Panda WMS