DM-49102 Remove Production related code from the web app#164
Merged
emanehab99 merged 5 commits intomainfrom Mar 11, 2025
Merged
DM-49102 Remove Production related code from the web app#164emanehab99 merged 5 commits intomainfrom
emanehab99 merged 5 commits intomainfrom
Conversation
ctslater
approved these changes
Mar 5, 2025
Member
ctslater
left a comment
ctslater
left a comment
There was a problem hiding this comment.
Looks good, with two small improvements noted.
src/lsst/cmservice/web_app/app.py
Outdated
| production_campaigns.append(campaign_details) | ||
| production_list[p.name] = production_campaigns | ||
|
|
||
| production_list: dict[str, list] = {} |
Member
There was a problem hiding this comment.
Making this a collections.defaultdict would avoid the need for an if-statement later.
src/lsst/cmservice/web_app/app.py
Outdated
| production_list: dict[str, list] = {} | ||
| campaigns = await get_all_campaigns(session) | ||
| for campaign in campaigns: | ||
| production_name = campaign.fullname.split("/")[0] |
Member
There was a problem hiding this comment.
I think production_name will eventually become part of the campaign object, so moving this string-parsing into get_campaign_details would make it easier to adjust in the future.
Member
|
Sorry I noticed one more thing: the "Steps" page has a go-back link that says the production name, but should be switched to something generic like "Back to Campaigns" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove any code that's using Production table as it will be deprecated soon