DM-51936 : Migrate tables for v2 feature development#183
Merged
tcjennings merged 1 commit intotickets/DM-51337/releasefrom Jul 7, 2025
Merged
DM-51936 : Migrate tables for v2 feature development#183tcjennings merged 1 commit intotickets/DM-51337/releasefrom
tcjennings merged 1 commit intotickets/DM-51337/releasefrom
Conversation
tcjennings
force-pushed
the
tickets/DM-51396/v2_tables
branch
from
f011891 to
b35ea06
Compare
Base automatically changed from
tickets/DM-51397/py312_types
to
tickets/DM-51337/release
June 24, 2025 14:28
tcjennings
force-pushed
the
tickets/DM-51396/v2_tables
branch
3 times, most recently
from
ac2ebfb to
7782fc0
Compare
feat(db): Extend v2 model fields with pydantic aliases
tcjennings
force-pushed
the
tickets/DM-51396/v2_tables
branch
from
7782fc0 to
4ece397
Compare
ctslater
approved these changes
Jul 7, 2025
Member
ctslater
left a comment
ctslater
left a comment
There was a problem hiding this comment.
Looks good. We talked through my main issue which was the Campaign/CampaignModel/CampaignBase structure, and since that is revised in later PRs then ok to go ahead with this one as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(db): Add migrations and models for v2 tables