DM-51488 : Create API Routes for v2 Campaigns and Manifests#184
Merged
tcjennings merged 15 commits intotickets/DM-51337/releasefrom Jul 15, 2025
Merged
DM-51488 : Create API Routes for v2 Campaigns and Manifests#184tcjennings merged 15 commits intotickets/DM-51337/releasefrom
tcjennings merged 15 commits intotickets/DM-51337/releasefrom
Conversation
9c5c71a to
d964b81
Compare
b35ea06 to
9dadfe3
Compare
4cfe1b3 to
33d58e3
Compare
9dadfe3 to
ac2ebfb
Compare
33d58e3 to
b7d311b
Compare
ac2ebfb to
7782fc0
Compare
9a3e1a2 to
5e4e92e
Compare
7782fc0 to
4ece397
Compare
bugfix(manifests): correct manifest name determination chore(tests): Implement tests for manifest routes feat(api): Extend and update v2 manifest routes
- add state machine db model - rearrange shared types and serde helpers - support arbitrary table schema in new db models and tests - Refactor validation function for enum fields - Add FK relations to model fields
feat(api): Refactor campaign and node routes
5e4e92e to
bcc2a96
Compare
feat(api): Refactor node and edge models
Base automatically changed from
tickets/DM-51396/v2_tables
to
tickets/DM-51337/release
July 7, 2025 17:05
- add crtime to element metadata - add manifests route for campaigns
ctslater
approved these changes
Jul 15, 2025
Member
ctslater
left a comment
There was a problem hiding this comment.
Lot of infrastructure here and all looks good, not much to suggest at all.
| ) -> Sequence[Campaign]: | ||
| """...""" | ||
| try: | ||
| campaigns = await session.exec(select(Campaign).offset(offset).limit(limit)) |
Member
There was a problem hiding this comment.
Same sorting issue as the other PR.
DM-51505 : Implement v2 Node and Edge routes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements additional models and routes for v2 campaigns and manifest CRUD operations.