DM-54101 : Allow Campaigns created by CLI to auto-start#236
Merged
tcjennings merged 4 commits intomainfrom Feb 10, 2026
Merged
Conversation
tcjennings
force-pushed
the
u/tobyj/w_2026_04
branch
3 times, most recently
from
a8f426a to
14ca480
Compare
tcjennings
force-pushed
the
u/tobyj/w_2026_04
branch
from
14ca480 to
c6a84c9
Compare
tcjennings
force-pushed
the
tickets/DM-52931/breakpoint
branch
from
e85baf1 to
1af4efa
Compare
tcjennings
force-pushed
the
u/tobyj/w_2026_04
branch
from
c6a84c9 to
9739c40
Compare
ctslater
approved these changes
Feb 10, 2026
packages/cm-commandline/src/lsst/cmservice/commandline/loader/app.py
Outdated
Show resolved
Hide resolved
| return str(campaign_id) | ||
| except ValueError: | ||
| return str(uuid5(settings.default_namespace, campaign)) | ||
| def as_snake_case(s: str) -> str: |
Member
There was a problem hiding this comment.
Is this function unused? Just checking that something isn't missing/this isn't an accident.
Collaborator
Author
There was a problem hiding this comment.
I intended to use it in the campaign name preprocessor callback.
Member
|
Not sure if there's a JIRA ticket I can't find for this, but this is a nice set of improvements. Only tiny comments. |
- Redact "waiting" (and "ready") states from campaign machine - Make "paused" default state - remove auto_transition spec flag - allow force on campaigns - ensure activity log entries even when no transition takes place
tcjennings
force-pushed
the
u/tobyj/w_2026_04
branch
from
9739c40 to
28a24ed
Compare
- Add strict mode definition to load option - Give strict mode option a default - Sanitize campaign name
tcjennings
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses improvements in the CLI and campaigns API.
loadcommand to "campaigns" with a--startoption, which will invoke a "campaign start" command immediately after completing a "load"