Skip to content

add s3nd_upload_attempts histogram metric#54

Merged
jhoblitt merged 1 commit intomainfrom
IT-6370/upload-attempts-histogram
Sep 8, 2025
Merged

add s3nd_upload_attempts histogram metric#54
jhoblitt merged 1 commit intomainfrom
IT-6370/upload-attempts-histogram

Conversation

@jhoblitt
Copy link
Copy Markdown
Member

@jhoblitt jhoblitt commented Sep 8, 2025

No description provided.

@jhoblitt jhoblitt self-assigned this Sep 8, 2025
@jhoblitt jhoblitt added the enhancement New feature or request label Sep 8, 2025
@jhoblitt jhoblitt requested a review from Copilot September 8, 2025 17:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new histogram metric to track the number of upload attempts per file transfer operation. The metric provides insight into upload reliability and potential retry patterns.

  • Introduces s3nd_upload_attempts histogram metric with native histogram configuration
  • Records the metric value from task.UploadAttempts during HTTP request processing
  • Updates test expectations to include the new metric in validation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
upload/handler.go Defines the new histogram metric and records its value during request handling
test/metrics_test.go Adds the new metric name to test validation list

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jhoblitt jhoblitt merged commit 073764c into main Sep 8, 2025
18 checks passed
@jhoblitt jhoblitt deleted the IT-6370/upload-attempts-histogram branch September 8, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants